From nobody Thu Feb 1 21:26:17 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TQsQy0RKgz58hXB; Thu, 1 Feb 2024 21:26:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TQsQx5QTpz4WRn; Thu, 1 Feb 2024 21:26:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706822777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qJww0QTDYa9+PdyF8WU9rMBckSKPX2NuxVGwAArE6Yc=; b=naOIqngut2lajJab+JQbJPH0DbqjSBY7cWljmAzV3gK+n+/Fxf7nOs9TlH42VBy5s6OMOf kWyXB5ut/KfaS9CVAtd8Y0DvBUB5l/n2OfaHwim45tofyZkVgawY5ircTZaldR4U3+FM9A 47C8NUHX44iHp+bRSrqA0hcZQBnQeogh9R5ViREi9/PB02E8xwPZ/x8bfA+M4mSFCJ/J6X 4ZU1E63EvnVu8mmPITNaj0xzvY3pTtOjojKZnKz88G5d9YOM2gwy2MScuQwoW0NyJwUuSw POnlPed+5LhwEK68N/5/NZpYZ+CZFFXv9+YI7mRLU68vsQNSvF2Tt8Oca5ewvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706822777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qJww0QTDYa9+PdyF8WU9rMBckSKPX2NuxVGwAArE6Yc=; b=AT8RcRvMbooxFIuI4CIHl9b9lgctbsTQ1K8laZb6x4dtK5xZDAq+F183RQq4kQiOFxLYMJ a1Paq98uZHSukYmnlt65AJGvu77+A7YHKuejqpDjSFyY3iW2ivipZQVXW4bitI5d4mhSu5 cJ7i4ixXSpc5dBEcQoZ3cwymLxI9E5IGKNHinqMvGJrFy6K1SSr6fTtK/3N49Fj/aS6cok aWd9yMkDEz+1Bm8PC1YhEiA5mDeLDMAvHRqpNvIYfmV0vuHNlwqH9wUOP68CgOSfQTp/Cs G6hs2H08bio+WPHQ4KjPFCkWlV/rC6DObjawI6GKAFbU40E7easTRDf7iWxR6A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706822777; a=rsa-sha256; cv=none; b=OpvmHobJsl+qvoqmmH2QH/mrgdyTnnYXkM0vLGvpf+x0Gp+4ck1ywF1mO+ChO1q6x4a6Q+ TFneMwK+gIErNVHu4zcCrdCkOgv9st1XK1OL9N8o6PZtuLt5dTaxZmavgXU2k/zgGAN/Tt hvNTnPQlsw+oWXIomxdqzlzIVvUKuP/V0IS7mJRixIyUx5a/fpWkyO/BigqKKu1dZIc5wG 0VyVj030QcgTidxIw2ZiMSSwX8PeYutzuu9ITv0WRXNC628W6LttoSozDp4eDjOfFiXO6A uy1skVVd7mxZOVZjpndu+yJkarzVQ8sckOAtOPZLmZnBUopvlrlXurWS3popRQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TQsQx4XSnz1HgV; Thu, 1 Feb 2024 21:26:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 411LQH6C070858; Thu, 1 Feb 2024 21:26:17 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 411LQHrh070855; Thu, 1 Feb 2024 21:26:17 GMT (envelope-from git) Date: Thu, 1 Feb 2024 21:26:17 GMT Message-Id: <202402012126.411LQHrh070855@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 634f86a3c47f - stable/13 - login_cap.h: Remove LOGIN_DEFPRI List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 634f86a3c47ffc8dfe7699ea599ab34c88b25324 Auto-Submitted: auto-generated The branch stable/13 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=634f86a3c47ffc8dfe7699ea599ab34c88b25324 commit 634f86a3c47ffc8dfe7699ea599ab34c88b25324 Author: Olivier Certner AuthorDate: 2024-01-25 22:25:10 +0000 Commit: Olivier Certner CommitDate: 2024-02-01 21:24:30 +0000 login_cap.h: Remove LOGIN_DEFPRI This is an implementation detail which is likely to become irrelevant in the future, as we move to not resetting the priority if the corresponding capability is not present in the configuration file ('/etc/login.conf'). GitHub's code search and Google show no use of this public constant, and it doesn't exist in OpenBSD and NetBSD. So, remove this definition and its sole use in-tree. PR: 276570 (exp-run) Reviewed by: emaste Approved by: emaste (mentor) MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D43609 (cherry picked from commit c7e645269f1c7e9872a7ccf6b72f045c55a66793) Approved by: markj (mentor) --- lib/libutil/login_cap.h | 1 - lib/libutil/login_class.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/libutil/login_cap.h b/lib/libutil/login_cap.h index a48246804a47..316d6e62d790 100644 --- a/lib/libutil/login_cap.h +++ b/lib/libutil/login_cap.h @@ -32,7 +32,6 @@ #define LOGIN_MECLASS "me" #define LOGIN_DEFSTYLE "passwd" #define LOGIN_DEFSERVICE "login" -#define LOGIN_DEFPRI 0 #define _PATH_LOGIN_CONF "/etc/login.conf" #define _FILE_LOGIN_CONF ".login_conf" #define _PATH_AUTHPROG "/usr/libexec/login_" diff --git a/lib/libutil/login_class.c b/lib/libutil/login_class.c index b4e52951bf9c..eb16ad501881 100644 --- a/lib/libutil/login_class.c +++ b/lib/libutil/login_class.c @@ -462,7 +462,7 @@ setlogincontext(login_cap_t *lc, const struct passwd *pwd, unsigned long flags) static void setclasspriority(login_cap_t * const lc, struct passwd const * const pwd) { - const rlim_t def_val = LOGIN_DEFPRI, err_val = INT64_MIN; + const rlim_t def_val = 0, err_val = INT64_MIN; rlim_t p; int rc;