From owner-freebsd-gnome@FreeBSD.ORG  Wed Feb 21 21:39:41 2007
Return-Path: <owner-freebsd-gnome@FreeBSD.ORG>
X-Original-To: gnome@FreeBSD.org
Delivered-To: freebsd-gnome@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B102016A400
	for <gnome@FreeBSD.org>; Wed, 21 Feb 2007 21:39:41 +0000 (UTC)
	(envelope-from notting@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31])
	by mx1.freebsd.org (Postfix) with ESMTP id 5BE8B13C4B7
	for <gnome@FreeBSD.org>; Wed, 21 Feb 2007 21:39:41 +0000 (UTC)
	(envelope-from notting@redhat.com)
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l1LLdemp030437;
	Wed, 21 Feb 2007 16:39:40 -0500
Received: from nostromo.devel.redhat.com (nostromo.devel.redhat.com
	[172.16.56.99])
	by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l1LLdeAl001931;
	Wed, 21 Feb 2007 16:39:40 -0500
Received: from nostromo.devel.redhat.com (nostromo.devel.redhat.com
	[127.0.0.1])
	by nostromo.devel.redhat.com (8.14.0/8.13.7) with ESMTP id
	l1LLb6ck014180; Wed, 21 Feb 2007 16:37:06 -0500
Received: (from notting@localhost)
	by nostromo.devel.redhat.com (8.14.0/8.14.0/Submit) id l1LLb5Ql014179; 
	Wed, 21 Feb 2007 16:37:05 -0500
Date: Wed, 21 Feb 2007 16:37:05 -0500
From: Bill Nottingham <notting@redhat.com>
To: Yoshihiro Ota <ota@j.email.ne.jp>
Message-ID: <20070221213705.GA14073@nostromo.devel.redhat.com>
Mail-Followup-To: Yoshihiro Ota <ota@j.email.ne.jp>, gnome@FreeBSD.org,
	obrien@NUXI.com, gnucash-devel@gnucash.org
References: <20070218163629.b861700d.ota@j.email.ne.jp>
	<20070221011853.6f32b0be.ota@j.email.ne.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070221011853.6f32b0be.ota@j.email.ne.jp>
User-Agent: Mutt/1.5.13 (2007-02-12)
Cc: gnome@FreeBSD.org, gnucash-devel@gnucash.org, obrien@NUXI.com
Subject: Re: gnucash patch
X-BeenThere: freebsd-gnome@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: GNOME for FreeBSD -- porting and maintaining
	<freebsd-gnome.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gnome>
List-Post: <mailto:freebsd-gnome@freebsd.org>
List-Help: <mailto:freebsd-gnome-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Feb 2007 21:39:41 -0000

Yoshihiro Ota (ota@j.email.ne.jp) said: 
> +--- src/gnome-utils/gnc-html.c.orig	Tue Feb 20 23:18:48 2007
> ++++ src/gnome-utils/gnc-html.c	Tue Feb 20 23:18:38 2007
> +@@ -1325,7 +1325,7 @@
> +     return;
> +   }
> + 
> +-  gtk_html_print(GTK_HTML(html->html), ps->context);
> ++  gtk_html_print_page(GTK_HTML(html->html), ps->context);
> +   gnc_print_session_done(ps);
> + }
> + 

It's nowhere near that simple. ps->context in gtk_html_print_page (for
new gtkhtml3) is a GtkPrintContext, not a GnomePrintContext. I strongly
supsect that making this change may make it build/link, but then all the
print-session.c gnome_print_* calls will blow up spectacularly.

Bill