Date: Tue, 23 Jul 2024 18:08:24 +0000 From: Zach Leslie <xaque208@gmail.com> To: Matthias Fechner <idefix@fechner.net> Cc: freebsd-ports@freebsd.org Subject: Re: Porting a new Golang app: go mod replace relative path Message-ID: <CACrr7Y4M28xAtnUJJjhT3_-HjK83ji-1Z1M4JrHCjVqW0k0K-g@mail.gmail.com> In-Reply-To: <CACrr7Y4vq6C6s-fOvHhDiwJSMs2eecBfF3jY9vrfD_2KX-zm4A@mail.gmail.com> References: <CACrr7Y5mDTZ4KONpWT4o_TnHWf4ZWuEtUgPNa31V0rpDHH6x5w@mail.gmail.com> <6d96a3de-1d87-4dab-aba0-90b45e554817@fechner.net> <epwi6vh5r5bsoiwqdaqvbx6niqt52e5v63mf7cku5ns6yhtqje@myp3skycuqtz> <b505fdb4-5cb5-468f-9cb0-2c9598ac7045@fechner.net> <CACrr7Y6JS0o1Os_ffm4MzEQ=nddoLNsp=vO190-jb4cgO66dNA@mail.gmail.com> <CACrr7Y4vq6C6s-fOvHhDiwJSMs2eecBfF3jY9vrfD_2KX-zm4A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000d9895b061dee0ca6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I have made some updates to the PR. Please advise if I should open a new PR to address the feedback. El mar, 23 de jul de 2024, 17:36, Zach Leslie <xaque208@gmail.com> escribi= =C3=B3: > I'm on mobile, but #279042 was filed. > > El mar, 23 de jul de 2024, 17:35, Zach Leslie <xaque208@gmail.com> > escribi=C3=B3: > >> Excellent thank you. There has been a new version and I'd like to updat= e >> soon. I'll pr and send an email next time. Btw, there is a bug for thi= s >> new port. >> >> El mar, 23 de jul de 2024, 05:34, Matthias Fechner <idefix@fechner.net> >> escribi=C3=B3: >> >>> Am 24.04.2024 um 18:26 schrieb Zach Leslie: >>> >> maybe by an additional manually added distfile entry to place it in >>> the >>> >> expected directly (maybe in a prefetch rule or by just manually >>> extending >>> >> the DIST_FILES). >>> > Thank you for the pointers. I was able to get something working and >>> > have submitted the following pull request for this new port. >>> > >>> > https://github.com/freebsd/freebsd-ports/pull/252 >>> > >>> I commited it, thanks for your contribution. >>> I you add github pull requests, make sure you always write to an email >>> list, as most of the committers work with the official bug tracker, but >>> they maybe do not monitor github. >>> >>> Gru=C3=9F >>> Matthias >>> >>> -- >>> >>> "Programming today is a race between software engineers striving to >>> build bigger and better idiot-proof programs, and the universe trying t= o >>> produce bigger and better idiots. So far, the universe is winning." -- >>> Rich Cook >>> >>> --000000000000d9895b061dee0ca6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <p dir=3D"ltr">I have made some updates to the PR.=C2=A0 Please advise if I= should open a new PR to address the feedback.</p> <br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">El mar= , 23 de jul de 2024, 17:36, Zach Leslie <<a href=3D"mailto:xaque208@gmai= l.com">xaque208@gmail.com</a>> escribi=C3=B3:<br></div><blockquote class= =3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd= ing-left:1ex"><p dir=3D"ltr">I'm on mobile, but #279042 was filed.</p> <br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">El mar= , 23 de jul de 2024, 17:35, Zach Leslie <<a href=3D"mailto:xaque208@gmai= l.com" target=3D"_blank" rel=3D"noreferrer">xaque208@gmail.com</a>> escr= ibi=C3=B3:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0= .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir=3D"ltr">Excellent= thank you.=C2=A0 There has been a new version and I'd like to update s= oon.=C2=A0 I'll pr and send an email next time.=C2=A0 Btw, there is a b= ug for this new port.</p> <br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">El mar= , 23 de jul de 2024, 05:34, Matthias Fechner <<a href=3D"mailto:idefix@f= echner.net" rel=3D"noreferrer noreferrer" target=3D"_blank">idefix@fechner.= net</a>> escribi=C3=B3:<br></div><blockquote class=3D"gmail_quote" style= =3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Am 24.04= .2024 um 18:26 schrieb Zach Leslie:<br> >> maybe by an additional manually added distfile entry to place it i= n the<br> >> expected directly (maybe in a prefetch rule or by just manually ex= tending<br> >> the DIST_FILES).<br> > Thank you for the pointers.=C2=A0 I was able to get something working = and<br> > have submitted the following pull request for this new port.<br> ><br> > <a href=3D"https://github.com/freebsd/freebsd-ports/pull/252" rel=3D"n= oreferrer noreferrer noreferrer noreferrer" target=3D"_blank">https://githu= b.com/freebsd/freebsd-ports/pull/252</a><br> ><br> I commited it, thanks for your contribution.<br> I you add github pull requests, make sure you always write to an email <br> list, as most of the committers work with the official bug tracker, but <br= > they maybe do not monitor github.<br> <br> Gru=C3=9F<br> Matthias<br> <br> -- <br> <br> "Programming today is a race between software engineers striving to<br= > build bigger and better idiot-proof programs, and the universe trying to<br= > produce bigger and better idiots. So far, the universe is winning." --= <br> Rich Cook<br> <br> </blockquote></div> </blockquote></div> </blockquote></div> --000000000000d9895b061dee0ca6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACrr7Y4M28xAtnUJJjhT3_-HjK83ji-1Z1M4JrHCjVqW0k0K-g>