From owner-freebsd-current@FreeBSD.ORG Wed Jun 14 17:43:09 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6F07B16A47D for ; Wed, 14 Jun 2006 17:43:09 +0000 (UTC) (envelope-from dialtone@gmail.com) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9EF8043D48 for ; Wed, 14 Jun 2006 17:43:08 +0000 (GMT) (envelope-from dialtone@gmail.com) Received: by wr-out-0506.google.com with SMTP id i34so183393wra for ; Wed, 14 Jun 2006 10:43:08 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=JG2w/7WfRrW3ob2yhYhwsdmwoVoMjKHPDHQava+z/XoM7ImRVZ0bFsIv9NseNCsI3aBmX2YeefOOjjyKqGClOdCT48W1z31DVa1WEXfGXxR31UcEdrcR0To7joZ8Xp9o1x/UPKA+Qkc9wJihna8Vnh4xJ1pJUk4UUapYZcg0THw= Received: by 10.54.91.3 with SMTP id o3mr872020wrb; Wed, 14 Jun 2006 10:43:07 -0700 (PDT) Received: by 10.54.72.14 with HTTP; Wed, 14 Jun 2006 10:43:06 -0700 (PDT) Message-ID: Date: Wed, 14 Jun 2006 19:43:06 +0200 From: "Valentino Volonghi" To: "Wojciech A. Koszek" In-Reply-To: <20060613233117.GA60384@FreeBSD.czest.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20060614010531.GA2033@FreeBSD.czest.pl> <20060613233117.GA60384@FreeBSD.czest.pl> Cc: freebsd-current@freebsd.org Subject: Re: (Should be: MemTrace -- simple tool for tracking memory leaks) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jun 2006 17:43:09 -0000 On 6/14/06, Wojciech A. Koszek wrote: > On Wed, Jun 14, 2006 at 01:05:31AM +0000, Wojciech A. Koszek wrote: > > Hello, > > And yes, it's better to set a message subject before sending. I haven't tested your patch yet, but from reading the tgz I can spot at least 2 typos in src/sys/vm/memtrace.c lines 129 and 132: static int memtrace_cache_misses; SYSCTL_INT(_vm_memtrace, OID_AUTO, misses, CTLFLAG_RD, &memtrace_cache_allocs, 0, "Number of misses to the MTrace cache"); static int memtrace_cache_gced; SYSCTL_INT(_vm_memtrace, OID_AUTO, gced, CTLFLAG_RD, &memtrace_cache_allocs, 0, "Number of garbage collected entries"); these should instead be: static int memtrace_cache_misses; SYSCTL_INT(_vm_memtrace, OID_AUTO, misses, CTLFLAG_RD, &memtrace_cache_misses, 0, "Number of misses to the MTrace cache"); static int memtrace_cache_gced; SYSCTL_INT(_vm_memtrace, OID_AUTO, gced, CTLFLAG_RD, &memtrace_cache_gced, 0, "Number of garbage collected entries"); everything else seems fine to me but I've _VERY_ little experience with FreeBSD internals and I'm just exploring it these days. HTH -- Valentino Volonghi aka Dialtone Now running MacOS X 10.4 Blog: http://vvolonghi.blogspot.com Home Page: http://xoomer.virgilio.it/dialtone/