From owner-freebsd-python@FreeBSD.ORG Sat Apr 12 04:53:47 2014 Return-Path: Delivered-To: python@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 33A9386E; Sat, 12 Apr 2014 04:53:47 +0000 (UTC) Received: from duck.symmetricom.us (duck.symmetricom.us [206.168.13.214]) by mx1.freebsd.org (Postfix) with ESMTP id E223B18B0; Sat, 12 Apr 2014 04:53:46 +0000 (UTC) Received: from gromit.timing.com (gromit.timing.com [206.168.13.209]) by duck.symmetricom.us (8.14.6/8.14.6) with ESMTP id s3C4rjVx025857; Fri, 11 Apr 2014 22:53:45 -0600 (MDT) (envelope-from jhein@symmetricom.com) Received: from gromit.timing.com (localhost [127.0.0.1]) by gromit.timing.com (8.14.7/8.14.5) with ESMTP id s3C4rjcs026804; Fri, 11 Apr 2014 22:53:45 -0600 (MDT) (envelope-from jhein@gromit.timing.com) Received: (from jhein@localhost) by gromit.timing.com (8.14.7/8.14.7/Submit) id s3C4rdZj026797; Fri, 11 Apr 2014 22:53:39 -0600 (MDT) (envelope-from jhein) Date: Fri, 11 Apr 2014 22:53:39 -0600 (MDT) Message-Id: <201404120453.s3C4rdZj026797@gromit.timing.com> To: FreeBSD-gnats-submit@freebsd.org Subject: [patch] devel/py-setuptoolXY: fix PYTHON_VERSION From: John Hein X-send-pr-version: 3.114 X-GNATS-Notify: Cc: python@freebsd.org X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: John Hein List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Apr 2014 04:53:47 -0000 >Submitter-Id: current-users >Originator: John Hein >Organization: >Confidential: no >Synopsis: [patch] devel/py-setuptoolXY: fix PYTHON_VERSION >Severity: non-critical >Priority: low >Category: ports >Class: change-request >Release: >Environment: >Description: The current settings in py-setuptools{27,32,33,34}/Makefile for PYTHON_VERSION are wrong (X.Y instead of pythonX.Y), but sort of work by chance rather than design. If it weren't for some unintended luck from the way _PYTHON_VERSION is set and the .MAKEFLAGS line in bsd.python.mk that forcibly sets PYTHON_VERSION=python${_PYTHON_VERSION}, these ports would fail with something like: Makefile error: bad value for PYTHON_VERSION: 3.3. Legal values are: python2.7 (default) python3.1 python3.2 python3.3 python3.4 >How-To-Repeat: >Fix: Index: py-setuptools27/Makefile =================================================================== --- py-setuptools27/Makefile (revision 350922) +++ py-setuptools27/Makefile (working copy) @@ -3,7 +3,7 @@ PKGNAMESUFFIX= ${PYTHON_SUFFIX} -PYTHON_VERSION= 2.7 +PYTHON_VERSION= python2.7 MASTERDIR= ${.CURDIR}/../py-setuptools Index: py-setuptools32/Makefile =================================================================== --- py-setuptools32/Makefile (revision 350922) +++ py-setuptools32/Makefile (working copy) @@ -3,7 +3,7 @@ PKGNAMESUFFIX= ${PYTHON_SUFFIX} -PYTHON_VERSION= 3.2 +PYTHON_VERSION= python3.2 MASTERDIR= ${.CURDIR}/../py-setuptools Index: py-setuptools33/Makefile =================================================================== --- py-setuptools33/Makefile (revision 350922) +++ py-setuptools33/Makefile (working copy) @@ -3,7 +3,7 @@ PKGNAMESUFFIX= ${PYTHON_SUFFIX} -PYTHON_VERSION= 3.3 +PYTHON_VERSION= python3.3 MASTERDIR= ${.CURDIR}/../py-setuptools Index: py-setuptools34/Makefile =================================================================== --- py-setuptools34/Makefile (revision 350922) +++ py-setuptools34/Makefile (working copy) @@ -3,7 +3,7 @@ PKGNAMESUFFIX= ${PYTHON_SUFFIX} -PYTHON_VERSION= 3.4 +PYTHON_VERSION= python3.4 MASTERDIR= ${.CURDIR}/../py-setuptools