Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 6 Nov 2018 07:41:32 +0000 (UTC)
From:      "Andrey V. Elsukov" <ae@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r340175 - head/sbin/ipfw
Message-ID:  <201811060741.wA67fWiL062421@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ae
Date: Tue Nov  6 07:41:32 2018
New Revision: 340175
URL: https://svnweb.freebsd.org/changeset/base/340175

Log:
  Do not print "ip6" keyword in print_icmp6types() for O_ICMP6TYPE opcode.
  
  It produces incompatibility when rules listing is used again to
  restore saved ruleset, because "ip6" keyword produces separate opcode.
  The kernel already has the check and only IPv6 packets will be checked
  for matching.
  
  PR:		232939
  MFC after:	3 days

Modified:
  head/sbin/ipfw/ipv6.c

Modified: head/sbin/ipfw/ipv6.c
==============================================================================
--- head/sbin/ipfw/ipv6.c	Tue Nov  6 02:52:54 2018	(r340174)
+++ head/sbin/ipfw/ipv6.c	Tue Nov  6 07:41:32 2018	(r340175)
@@ -169,7 +169,7 @@ print_icmp6types(struct buf_pr *bp, ipfw_insn_u32 *cmd
 	int i, j;
 	char sep= ' ';
 
-	bprintf(bp, " ip6 icmp6types");
+	bprintf(bp, " icmp6types");
 	for (i = 0; i < 7; i++)
 		for (j=0; j < 32; ++j) {
 			if ( (cmd->d[i] & (1 << (j))) == 0)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201811060741.wA67fWiL062421>