From owner-svn-src-projects@FreeBSD.ORG  Mon Jan 19 18:17:22 2015
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 6F988B0;
 Mon, 19 Jan 2015 18:17:22 +0000 (UTC)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5BD3A232;
 Mon, 19 Jan 2015 18:17:22 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.9/8.14.9) with ESMTP id t0JIHMpx064355;
 Mon, 19 Jan 2015 18:17:22 GMT (envelope-from gjb@FreeBSD.org)
Received: (from gjb@localhost)
 by svn.freebsd.org (8.14.9/8.14.9/Submit) id t0JIHLYD064353;
 Mon, 19 Jan 2015 18:17:21 GMT (envelope-from gjb@FreeBSD.org)
Message-Id: <201501191817.t0JIHLYD064353@svn.freebsd.org>
X-Authentication-Warning: svn.freebsd.org: gjb set sender to gjb@FreeBSD.org
 using -f
From: Glen Barber <gjb@FreeBSD.org>
Date: Mon, 19 Jan 2015 18:17:21 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject: svn commit: r277393 - in projects/release-vmimage/release: scripts
 tools
X-SVN-Group: projects
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Jan 2015 18:17:22 -0000

Author: gjb
Date: Mon Jan 19 18:17:21 2015
New Revision: 277393
URL: https://svnweb.freebsd.org/changeset/base/277393

Log:
  Remove the pkg-clean(8) call from vm_extra_pre_umount()
  since the function is often overridden.
  
  Add vm_extra_pkg_rmcache() to call pkg-clean(8) to avoid
  duplicated code.
  
  Sponsored by:	The FreeBSD Foundation

Modified:
  projects/release-vmimage/release/scripts/mk-vmimage.sh
  projects/release-vmimage/release/tools/vmimage.subr

Modified: projects/release-vmimage/release/scripts/mk-vmimage.sh
==============================================================================
--- projects/release-vmimage/release/scripts/mk-vmimage.sh	Mon Jan 19 17:58:01 2015	(r277392)
+++ projects/release-vmimage/release/scripts/mk-vmimage.sh	Mon Jan 19 18:17:21 2015	(r277393)
@@ -100,6 +100,7 @@ main() {
 	vm_extra_install_ports
 	vm_extra_enable_services
 	vm_extra_pre_umount
+	vm_extra_pkg_rmcache
 	cleanup
 	vm_create_disk || return 0
 	vm_extra_create_disk

Modified: projects/release-vmimage/release/tools/vmimage.subr
==============================================================================
--- projects/release-vmimage/release/tools/vmimage.subr	Mon Jan 19 17:58:01 2015	(r277392)
+++ projects/release-vmimage/release/tools/vmimage.subr	Mon Jan 19 18:17:21 2015	(r277393)
@@ -146,6 +146,10 @@ vm_extra_pre_umount() {
 	# Prototype.  When overridden, installs additional ports within the
 	# virtual machine environment.
 
+	return 0
+}
+
+vm_extra_pkg_rmcache() {
 	if [ -e ${DESTDIR}/usr/local/sbin/pkg ]; then
 		chroot ${DESTDIR} env ASSUME_ALWAYS_YES=yes \
 			/usr/local/sbin/pkg clean -y -a