From owner-freebsd-bugs@FreeBSD.ORG Sat May 21 23:50:03 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 40AF416A41C for ; Sat, 21 May 2005 23:50:03 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id A9F8843D4C for ; Sat, 21 May 2005 23:50:02 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j4LNo2VF039736 for ; Sat, 21 May 2005 23:50:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j4LNo2V1039735; Sat, 21 May 2005 23:50:02 GMT (envelope-from gnats) Resent-Date: Sat, 21 May 2005 23:50:02 GMT Resent-Message-Id: <200505212350.j4LNo2V1039735@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Wojciech A. Koszek" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE29416A41C for ; Sat, 21 May 2005 23:47:10 +0000 (GMT) (envelope-from dunstan@freebsd.czest.pl) Received: from freebsd.czest.pl (silver.iplus.pl [80.48.250.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 57DE743D1F for ; Sat, 21 May 2005 23:47:09 +0000 (GMT) (envelope-from dunstan@freebsd.czest.pl) Received: from freebsd.czest.pl (freebsd.czest.pl [80.48.250.4]) by freebsd.czest.pl (8.12.10/8.12.9) with ESMTP id j4LNw7Lh043522 for ; Sat, 21 May 2005 23:58:08 GMT (envelope-from dunstan@freebsd.czest.pl) Received: (from dunstan@localhost) by freebsd.czest.pl (8.12.10/8.12.9/Submit) id j4LNw7fo043521; Sat, 21 May 2005 23:58:07 GMT (envelope-from dunstan) Message-Id: <200505212358.j4LNw7fo043521@freebsd.czest.pl> Date: Sat, 21 May 2005 23:58:07 GMT From: "Wojciech A. Koszek" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/81349: [PATCH] Wrong error code is returned in ng_eiface(4) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: "Wojciech A. Koszek" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 May 2005 23:50:03 -0000 >Number: 81349 >Category: kern >Synopsis: [PATCH] Wrong error code is returned in ng_eiface(4) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat May 21 23:50:02 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Wojciech A. Koszek >Release: FreeBSD 5.4-STABLE i386 >Organization: >Environment: System: FreeBSD dunstan.freebsd.czest.pl 5.4-STABLE FreeBSD 5.4-STABLE #5: Sun May 8 11:57:11 CEST 2005 dunstan@dunstan.freebsd.czest.pl:/usr/obj/usr/src/sys/HOME8 i386 >Description: Other Netgraph nodes return EINVAL when we try to create hook with name which is not handled (of course, for modules which functionality rely on hooks' names). Currently, ng_eiface(4) returns EPFNOSUPPORT, which is less obvious while being configurated than proper -- EINVAL. >How-To-Repeat: # ngctl [..] + mkpeer . eiface input xXxX ngctl: send msg: Protocol family not supported ('xXxX' instead of 'ether', which is required for ng_eiface(4)). >Fix: Patch [diff.0.ng_eiface.c] replaces EPFNOSUPPORT with EINVAL. --- diff.0.ng_eiface.c begins here --- Index: src/sys/netgraph/ng_eiface.c =================================================================== RCS file: /home/ncvs/src/sys/netgraph/ng_eiface.c,v retrieving revision 1.31 diff -r1.31 ng_eiface.c 384c384 < return (EPFNOSUPPORT); --- > return (EINVAL); --- diff.0.ng_eiface.c ends here --- >Release-Note: >Audit-Trail: >Unformatted: