From owner-svn-src-head@freebsd.org Wed Feb 7 09:35:28 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 027ABEED7CE; Wed, 7 Feb 2018 09:35:28 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: from mail-qt0-f173.google.com (mail-qt0-f173.google.com [209.85.216.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9B2297F693; Wed, 7 Feb 2018 09:35:27 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: by mail-qt0-f173.google.com with SMTP id r13so251823qtm.8; Wed, 07 Feb 2018 01:35:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=aL9CPJlzN0932/2dEozEt1tCll16j1F/1KxYuWDyyXo=; b=e5cLz3sueH+sqeleZjMfglR0okNqa8NLDutVq2eZ7zgzugcICtlJB8Kw941+TI2ovX LOeLGXR60BaNrOeL5JujJIOtKYc9JFgGp2albpAT/os88O6oMKLme/LxSvag7qD2dFIq iqHWQeC20ZIajkN779TaWQRc74+TkQ2HG03cta6EsyngVaBGq5Hj6KVaN0KCx8YU1eBu Ie6mHDoPMk0eLSihrRBH5FoKeU3OEn3I2GiShfuBvGe3hv3wfx/bjId8nYIC80ozJdgb ogI73KCm5hi6LXNMMujuJDxoJ4CYNYW77pWaqdp3SiEnOvQVkHO5Y9nX0lawez/F/16C rfrA== X-Gm-Message-State: APf1xPBcYKczQ/RvjoBMCsl2+NLwp+OtTniyLCAD+XcYVavn+ysg4ltn y1EX8LbB/e+SdmtgBHBuKZyfTdOl/c4= X-Google-Smtp-Source: AH8x224AdmEr0RfBGhCNuFregDidU40CHZ5mSchxJAwsiUjWChlPAXIlKRQC2Dc8CVgQ13AfkIv6Fw== X-Received: by 10.200.13.193 with SMTP id t1mr623373qti.287.1517996120918; Wed, 07 Feb 2018 01:35:20 -0800 (PST) Received: from mail-qt0-f181.google.com (mail-qt0-f181.google.com. [209.85.216.181]) by smtp.gmail.com with ESMTPSA id r62sm699121qkc.52.2018.02.07.01.35.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Feb 2018 01:35:20 -0800 (PST) Received: by mail-qt0-f181.google.com with SMTP id t25so265603qtg.3; Wed, 07 Feb 2018 01:35:20 -0800 (PST) X-Received: by 10.237.51.161 with SMTP id v30mr8582547qtd.27.1517996120443; Wed, 07 Feb 2018 01:35:20 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.85.47 with HTTP; Wed, 7 Feb 2018 01:34:59 -0800 (PST) In-Reply-To: <201802061925.w16JP4aq017961@pdx.rh.CN85.dnsmgr.net> References: <201802061541.w16FfadO041469@repo.freebsd.org> <201802061925.w16JP4aq017961@pdx.rh.CN85.dnsmgr.net> From: Alexander Richardson Date: Wed, 7 Feb 2018 09:34:59 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r328934 - in head: . bin/sh To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 09:35:28 -0000 On 6 February 2018 at 19:25, Rodney W. Grimes wrote: >> Author: arichardson >> Date: Tue Feb 6 15:41:35 2018 >> New Revision: 328934 >> URL: https://svnweb.freebsd.org/changeset/base/328934 >> >> Log: >> Don't hardcode /usr/bin as the path for mktemp in build tools >> >> It won't work e.g. when crossbuilding from Ubuntu Linux as mktemp is i= n >> /bin there. >> >> Reviewed By: bdrewery >> Approved By: jhb (mentor) >> Differential Revision: https://reviews.freebsd.org/D13937 > > Would it be better to create the variable MKTEMP to point at > either /bin/mktemp or /usr/bin/mktemp dependent on platform, > there are reasons we use full paths in Makefiles, mostly to > stop /usr/local/bin/foo contimaton, which I believe this > change now opens up, though very slight as I dont know of > a third party mktemp binary. > I'm happy to have a mktemp variable instead, but I don't believe files in /usr/local/bin are a problem. When in add an echo $PATH to the mktokens.sh file I get the following output: PATH=3D/home/alr48/obj/build/freebsd-mips-build/exports/users/alr48/sources= /freebsd-mips/mips.mips64/tmp/legacy/usr/sbin:/home/alr48/obj/build/freebsd= -mips-build/exports/users/alr48/sources/freebsd-mips/mips.mips64/tmp/legacy= /usr/bin:/home/alr48/obj/build/freebsd-mips-build/exports/users/alr48/sourc= es/freebsd-mips/mips.mips64/tmp/legacy/bin:/home/alr48/obj/build/freebsd-mi= ps-build/exports/users/alr48/sources/freebsd-mips/mips.mips64/tmp/usr/sbin:= /home/alr48/obj/build/freebsd-mips-build/exports/users/alr48/sources/freebs= d-mips/mips.mips64/tmp/usr/bin:/sbin:/bin:/usr/sbin:/usr/bin This only contains WORLDTMP and /sbin:/bin:/usr/sbin:/usr/bin since the toplevel makefile already sets PATH to /sbin:/bin:/usr/sbin:/usr/bin.