From owner-freebsd-net@freebsd.org Tue Nov 28 19:32:28 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3A18ADEC494 for ; Tue, 28 Nov 2017 19:32:28 +0000 (UTC) (envelope-from bryanv@daemoninthecloset.org) Received: from mail-lf0-x22f.google.com (mail-lf0-x22f.google.com [IPv6:2a00:1450:4010:c07::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B33A874E69 for ; Tue, 28 Nov 2017 19:32:27 +0000 (UTC) (envelope-from bryanv@daemoninthecloset.org) Received: by mail-lf0-x22f.google.com with SMTP id 74so1138426lfs.0 for ; Tue, 28 Nov 2017 11:32:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daemoninthecloset.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=BYe1zGU8wBOlK7gqcqxiAKmX8sPyRAKoEaKFHnS5yzA=; b=iloqTAONBw7QGiq6TJFVUSyBO3vff540q/lqhBFXGuX0ro1aeSE8ulz3gwKofQWSrS VgpGNS6pVb/uw7Mn/9yqUBKpG5mDgYf9/+WWBngpuE636TiEaSe+vobn9ygwmqtrwtC7 6HsCeOR0UTVXKuYauUPeQsi3K/sK8fksnYytPFy27wgUcVxChnklobqBQUA2OFWlurdQ XOvjHdsmJYsCLrX2n0gnB1t75fZ1DDJa1xVJ7LchhLb2K/HXNy26vJOItRV20G2GyuW6 S1zA/yc7R+Cmvcf/RpaPbmoyqH5rcn5yQJlOMwlQTNSZc97x1dXyJyxVecLG2P7kRVXA Gohw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BYe1zGU8wBOlK7gqcqxiAKmX8sPyRAKoEaKFHnS5yzA=; b=ottAEDzmn9Lqod1gHcovTsDbLopsCATsuuHEpDVHxQfj2k/r2Kr5fJcc6aQes6H8n6 qY64mJassmTsZefV9U8OP33wj5iZ1Uhqv3NpM0yznQz0Knh0pMfWeHl735s8dHon7w5I zpnnb6yKe8fCBqAOz8GESTYB5RRY+T6Sdlu9ByI0MIOHXHNGAA/8a4vQb4hoR+VoIiVw CgPLMeCAQSQrRB9BG9H5q9/go7XVIYiiJjU/lajs7kzLHFVkgfwGmm4aiUUlcWq9OwSf A93LLv2LEk+d2LDiFXblF0lnJa5ED0+YuBtTSZdUb7wiamFF+FNR0E+iWLCvr+XfudvA BFPw== X-Gm-Message-State: AJaThX4N5GCB1g71meT9GjdBDOQh2OlCmH1OGGGFBJHOyt8LmNQm2E5o KGDew6MdPhRKgUXm+Su+lZLkpQdpFUOMShucn5iNCvvv X-Google-Smtp-Source: AGs4zMbTvq6X4udX/ar7K9KkoC7U5Jp3FCpgYCMUr6LFKc+VU3G7L+RAsQQqd8ftv/xSXd/89kQ42VZSX0qPUC361b8= X-Received: by 10.46.4.207 with SMTP id a76mr139526ljf.6.1511897545849; Tue, 28 Nov 2017 11:32:25 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.235.217 with HTTP; Tue, 28 Nov 2017 11:32:05 -0800 (PST) In-Reply-To: <0536294F-3709-4E38-AD7C-1A809AAD13A6@perftech.com> References: <398971232.399523.1508250252244.JavaMail.zimbra@perftech.com> <0536294F-3709-4E38-AD7C-1A809AAD13A6@perftech.com> From: Bryan Venteicher Date: Tue, 28 Nov 2017 13:32:05 -0600 Message-ID: Subject: Re: vmxnet3 driver bug? To: Lewis Donzis Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 19:32:28 -0000 On Tue, Oct 17, 2017 at 9:36 AM, Lewis Donzis wrote: > The VMXNET3 driver appears to have a bug that prevents it from correctly > reporting when the link goes down. > > There are two lines of code that should be deleted in > /usr/src/sys/dev/vmware/vmxnet3/if_vmx.c: > > @@ -3619,8 +3619,6 @@ vmxnet3_media_status(struct ifnet *ifp, struct > ifmediareq *ifmr) > VMXNET3_CORE_LOCK(sc); > if (vmxnet3_link_is_up(sc) !=3D 0) > ifmr->ifm_status |=3D IFM_ACTIVE; > - else > - ifmr->ifm_status |=3D IFM_NONE; > VMXNET3_CORE_UNLOCK(sc); > } > > IFM_NONE doesn=E2=80=99t belong in the status flags and, coincidentally, = is > defined with an identical value as IFM_ACTIVE, so it indicates that link = is > always active. > > This should be fixed in r326309 that I'll merge to the stable branches in a week. > Thanks, > lew > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"