From owner-cvs-all@FreeBSD.ORG  Thu Jun 30 11:33:10 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B54F51065675;
	Thu, 30 Jun 2011 11:33:10 +0000 (UTC)
	(envelope-from jlaffaye.freebsd@gmail.com)
Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com
	[74.125.82.182])
	by mx1.freebsd.org (Postfix) with ESMTP id C04258FC14;
	Thu, 30 Jun 2011 11:33:09 +0000 (UTC)
Received: by wyg24 with SMTP id 24so2021480wyg.13
	for <multiple recipients>; Thu, 30 Jun 2011 04:33:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject
	:references:in-reply-to:x-enigmail-version:content-type
	:content-transfer-encoding;
	bh=9MQDdl3AqzZspeWaeXIAmeexZh6gvSh525LP16xIWgM=;
	b=CxtPEGrh70xC1e4VcORjQJ+uxJldVrFsFM3l2BZzrw/QFj8yjQUnmtmtT6EBkz6JGU
	qyVCZNq4fhJsPs8wxF2y0qYnCEaQAbD67uKlHn70NSFbJyj04x95QyRSzNyDN98XCgq6
	8E2LN2KSt2riyohN/cEhZnEbiIxQOb0+rTNy0=
Received: by 10.227.202.205 with SMTP id ff13mr1720904wbb.102.1309432258585;
	Thu, 30 Jun 2011 04:10:58 -0700 (PDT)
Received: from chulak.jlaffaye.net
	(cpc1-oxfd15-0-0-cust230.4-3.cable.virginmedia.com [82.24.248.231])
	by mx.google.com with ESMTPS id fp5sm324393wbb.32.2011.06.30.04.10.57
	(version=SSLv3 cipher=OTHER); Thu, 30 Jun 2011 04:10:57 -0700 (PDT)
Sender: Julien Laffaye <jlaffaye.freebsd@gmail.com>
Message-ID: <4E0C59C1.8080605@FreeBSD.org>
Date: Thu, 30 Jun 2011 12:10:57 +0100
From: Julien Laffaye <jlaffaye@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.18) Gecko/20110625 Thunderbird/3.1.11
MIME-Version: 1.0
To: Sahil Tandon <sahil@FreeBSD.org>
References: <201106291951.p5TJpHh7000414@repoman.freebsd.org>
	<20110630032003.GA670@magic.hamla.org>
In-Reply-To: <20110630032003.GA670@magic.hamla.org>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/lang/php52 Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jun 2011 11:33:10 -0000

On 06/30/2011 04:20, Sahil Tandon wrote:
> On Wed, 2011-06-29 at 19:51:17 +0000, Julien Laffaye wrote:
> 
>>   Modified files:
>>     lang/php52           Makefile 
>>   Log:
>>   Add an option to link against libthr
>>   
>>   PR:             ports/158423
>>   Submitted by:   Frank Wall <fw@moov.de>
>>   Approved by:    Alex Keda <admin@lissyara.su> (maintainer), bapt (mentor, implicit)
>>   
>>   Revision  Changes    Path
>>   1.18      +7 -1      ports/lang/php52/Makefile
> 
> Why bump PORTREVISION if the new option is off by default and does not
> affect the default package?  This is sometimes a grey area, so please do
> not misconstrue my question for hostility; I just want to understand
> your rationale.  For context, ale@ added the LINKTHR option to lang/php5
> last year without a bump:
> 
> http://www.freebsd.org/cgi/cvsweb.cgi/ports/lang/php5/Makefile.diff?r1=1.147;r2=1.148
> 

I could have sworn that I removed it after applying the PR patch.
Apparently that was not the case :( Sorry for that.