Date: Thu, 30 Jun 2011 12:10:57 +0100 From: Julien Laffaye <jlaffaye@FreeBSD.org> To: Sahil Tandon <sahil@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/lang/php52 Makefile Message-ID: <4E0C59C1.8080605@FreeBSD.org> In-Reply-To: <20110630032003.GA670@magic.hamla.org> References: <201106291951.p5TJpHh7000414@repoman.freebsd.org> <20110630032003.GA670@magic.hamla.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/30/2011 04:20, Sahil Tandon wrote: > On Wed, 2011-06-29 at 19:51:17 +0000, Julien Laffaye wrote: > >> Modified files: >> lang/php52 Makefile >> Log: >> Add an option to link against libthr >> >> PR: ports/158423 >> Submitted by: Frank Wall <fw@moov.de> >> Approved by: Alex Keda <admin@lissyara.su> (maintainer), bapt (mentor, implicit) >> >> Revision Changes Path >> 1.18 +7 -1 ports/lang/php52/Makefile > > Why bump PORTREVISION if the new option is off by default and does not > affect the default package? This is sometimes a grey area, so please do > not misconstrue my question for hostility; I just want to understand > your rationale. For context, ale@ added the LINKTHR option to lang/php5 > last year without a bump: > > http://www.freebsd.org/cgi/cvsweb.cgi/ports/lang/php5/Makefile.diff?r1=1.147;r2=1.148 > I could have sworn that I removed it after applying the PR patch. Apparently that was not the case :( Sorry for that.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E0C59C1.8080605>