From nobody Wed Jun 4 21:26:03 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bCLH003KTz5xfMh; Wed, 04 Jun 2025 21:26:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bCLGz4xyXz4DW3; Wed, 04 Jun 2025 21:26:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749072363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=n849SiRQvy2CKyWVuYXDSmJse++Cp3liwJXVeIlQ8iM=; b=FRgjZv80Xw3oVEEGyJY7/jrYtTw/IvQfyv0RMIpWjAl5oXqnHZYz6uU3Oe2eNGst2tji0b W74QKJzemRFkWil+Zpfp1UW6VuVUjYpVwadCrLNBdNxwvBF9sdUsi9+yJuASj8EvHiICd5 ynl1WfGmSI29+jQaWC/dqu5lrjHldf02CpM3SNFy3Hu4euHHPWbb57dkjvaMJExcwvgMmc XdlV+cdvMMhu3pB+Xn8/+WyYdr/E3AiHGB0mx+nipOE2ZWfA4/i1vNehGVqGzqVN8LScf1 azgRBW1JZrWUCjAgFnrUnMBaI/kO5UlC0caX0Zbb8VtCNyGi41/XyCcWl19wDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749072363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=n849SiRQvy2CKyWVuYXDSmJse++Cp3liwJXVeIlQ8iM=; b=Z/f9MMugb4c6DTeK24ebBxza7cs68UhcEtcGHiPG8Va64gRYCaxdbggFYbxUf7cqTRdSNh 1aFPPuZmC8nQ70JQA07rPxaFFQ7+Cj64ynoZ7cKZmzg8fd+iZZfCPvMSejQxJ0LKBl4L6G GxxXH7lU+/8JBcvOoauoKMBK4ieD5FF2NbnN2gOR55CxLWoGj/vaeA2xB9IoHj5h7lzIJz S3CtLjqM51scAEIaCF0fuSjr47QHk5c+9mQrVi5S0KRJygkKAkNm1wujPwqhE4TNf1AUX3 3Un77Ddh72OSLqpsdv/HHwfyI9aQjHq2eum3aSB0IYUEuWnhCMVPxrHlIDAWsA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1749072363; a=rsa-sha256; cv=none; b=Kscyk1IBPoz0DYNj76y3GE+mW+XwIfn02bSPZS2H2ya6KND36JmB3nGW+/M+5/SQqnY/AE Lsuz7/zILV4UsafTB6A6PTF+RrfDPEPUCVVpBJhWtbUTSHiNxiyV0vrCfav8MBGUXCCQlK iLAMF3jWlRJZDZYmBLNXejP6fTfcVTKg9aw48xCW7L/9Wi9pyU1rklm5C6Dtyq2CWT+cen Cq4VlhX/z/M3WtGPw8lv70v2FknyOjQD4x5p3Kd73lCxXeRLbfCADsxbz3Wd8FI2h54D/r 7a+d6YysgvztzKH9iiNpWpvQ6yeA+0KWeVODckbqSkH4UkxXUpYefjvf0GqgAQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bCLGz4TtqzhDY; Wed, 04 Jun 2025 21:26:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 554LQ35J025406; Wed, 4 Jun 2025 21:26:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 554LQ31s025403; Wed, 4 Jun 2025 21:26:03 GMT (envelope-from git) Date: Wed, 4 Jun 2025 21:26:03 GMT Message-Id: <202506042126.554LQ31s025403@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 98ef590f7739 - main - dtrace/profile: Stop storing the probe name in struct profile_probe List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 98ef590f77392159938d2e6f9fd45bf31d10b9c1 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=98ef590f77392159938d2e6f9fd45bf31d10b9c1 commit 98ef590f77392159938d2e6f9fd45bf31d10b9c1 Author: Mark Johnston AuthorDate: 2025-06-04 21:13:08 +0000 Commit: Mark Johnston CommitDate: 2025-06-04 21:13:08 +0000 dtrace/profile: Stop storing the probe name in struct profile_probe It's unused, and the naked strcpy() was susceptible to buffer overflow if one creates, say, a probe called "profile-2000000000ns". Reported by: CHERI MFC after: 1 week Sponsored by: Innovate UK --- sys/cddl/dev/profile/profile.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/cddl/dev/profile/profile.c b/sys/cddl/dev/profile/profile.c index 677c7543795f..3e106aab1c85 100644 --- a/sys/cddl/dev/profile/profile.c +++ b/sys/cddl/dev/profile/profile.c @@ -118,7 +118,6 @@ struct profile_probe_percpu; #endif typedef struct profile_probe { - char prof_name[PROF_NAMELEN]; dtrace_id_t prof_id; int prof_kind; #ifdef illumos @@ -302,7 +301,6 @@ profile_create(hrtime_t interval, char *name, int kind) } prof = kmem_zalloc(sizeof (profile_probe_t), KM_SLEEP); - (void) strcpy(prof->prof_name, name); #ifdef illumos prof->prof_interval = interval; prof->prof_cyclic = CYCLIC_NONE;