From owner-cvs-src@FreeBSD.ORG Mon Jul 9 20:11:18 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6340F16A468; Mon, 9 Jul 2007 20:11:18 +0000 (UTC) (envelope-from ler@lerctr.org) Received: from thebighonker.lerctr.org (thebighonker.lerctr.org [192.147.25.65]) by mx1.freebsd.org (Postfix) with ESMTP id 3B11713C4BE; Mon, 9 Jul 2007 20:11:18 +0000 (UTC) (envelope-from ler@lerctr.org) Received: from dia.lan128.lombardisoftware.com ([64.3.1.253]:7791 helo=LROSENMAN) by thebighonker.lerctr.org with esmtpa (Exim 4.67 (FreeBSD)) (envelope-from ) id 1I7z8N-000EGb-9z; Mon, 09 Jul 2007 14:43:01 -0500 From: "Larry Rosenman" To: "'Warner Losh'" , , , References: <200707091658.l69Gw8MG080618@repoman.freebsd.org> In-Reply-To: <200707091658.l69Gw8MG080618@repoman.freebsd.org> Date: Mon, 9 Jul 2007 14:42:48 -0500 Message-ID: <023401c7c261$5ab499b0$101dcd10$@org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: AcfCSm3ekbHq7VAeTKGMmAlXjY+ffQAFuHNA Content-Language: en-us X-Spam-Score: -4.3 (----) X-LERCTR-Spam-Score: -4.3 (----) X-Spam-Report: SpamScore (-4.3/5.0) ALL_TRUSTED=-1.8, BAYES_00=-2.599, DKIM_POLICY_SIGNSOME=0, TW_SK=0.077 X-LERCTR-Spam-Report: SpamScore (-4.3/5.0) ALL_TRUSTED=-1.8, BAYES_00=-2.599, DKIM_POLICY_SIGNSOME=0, TW_SK=0.077 DomainKey-Status: no signature Cc: Subject: RE: cvs commit: src/sys/dev/usb if_rue.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2007 20:11:18 -0000 ===> rue (all) cc -O1 -pipe -D_KERNEL -DKLD_MODULE -std=c99 -nostdinc -DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/sys/BORG/opt_global.h -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -g -fno-omit-frame-pointer -I/usr/obj/usr/src/sys/BORG -mcmodel=kernel -mno-red-zone -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -c /usr/src/sys/modules/rue/../../dev/usb/if_rue.c /usr/src/sys/modules/rue/../../dev/usb/if_rue.c: In function 'rue_attach': /usr/src/sys/modules/rue/../../dev/usb/if_rue.c:598: error: 'struct rue_softc' has no member named 'rue_tick_task' /usr/src/sys/modules/rue/../../dev/usb/if_rue.c:598: error: 'struct rue_softc' has no member named 'rue_tick_task' /usr/src/sys/modules/rue/../../dev/usb/if_rue.c:598: warning: left-hand operand of comma expression has no effect /usr/src/sys/modules/rue/../../dev/usb/if_rue.c:598: error: 'struct rue_softc' has no member named 'rue_tick_task' /usr/src/sys/modules/rue/../../dev/usb/if_rue.c:598: warning: left-hand operand of comma expression has no effect /usr/src/sys/modules/rue/../../dev/usb/if_rue.c: In function 'rue_detach': /usr/src/sys/modules/rue/../../dev/usb/if_rue.c:710: error: 'struct rue_softc' has no member named 'rue_tick_task' /usr/src/sys/modules/rue/../../dev/usb/if_rue.c: In function 'rue_tick': /usr/src/sys/modules/rue/../../dev/usb/if_rue.c:931: error: 'struct rue_softc' has no member named 'rue_tick_task' *** Error code 1 Stop in /usr/src/sys/modules/rue. *** Error code 1 Stop in /usr/src/sys/modules. *** Error code 1 Stop in /usr/obj/usr/src/sys/BORG. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. ^C[1] + Done(1) make buildkernel >make.bk.out 2>&1 & # -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 512-248-2683 E-Mail: ler@lerctr.org US Mail: 430 Valona Loop, Round Rock, TX 78681-3893 -----Original Message----- From: owner-cvs-all@freebsd.org [mailto:owner-cvs-all@freebsd.org] On Behalf Of Warner Losh Sent: Monday, July 09, 2007 11:58 AM To: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/usb if_rue.c imp 2007-07-09 16:58:08 UTC FreeBSD src repository Modified files: sys/dev/usb if_rue.c Log: When all the other drivers were converted to scheduling a taskqueue to do the heavy lifting of the 'mii_tick' function, rue was left behind. Implement this in a naive way. Reports from the field show this makes the driver functional with some locking issues, as opposed to an instant panic. Those will be addressed in a later version of the driver. Approved by: re@ (bmah) Revision Changes Path 1.40 +18 -0 src/sys/dev/usb/if_rue.c _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"