From owner-cvs-all Thu Aug 24 1:24:24 2000 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (beachchick.freebsd.dk [212.242.34.254]) by hub.freebsd.org (Postfix) with ESMTP id 290DE37B423; Thu, 24 Aug 2000 01:24:02 -0700 (PDT) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.9.3/8.9.3) with ESMTP id KAA06193; Thu, 24 Aug 2000 10:23:00 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Peter Jeremy Cc: Brian Somers , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/games/fortune/datfiles fortunes In-Reply-To: Your message of "Thu, 24 Aug 2000 08:51:24 +1000." <00Aug24.085126est.115204@border.alcanet.com.au> Date: Thu, 24 Aug 2000 10:23:00 +0200 Message-ID: <6191.967105380@critter> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <00Aug24.085126est.115204@border.alcanet.com.au>, Peter Jeremy write s: >On 2000-Aug-23 18:00:50 +0100, Brian Somers wrote: >>> On Sat, Aug 19, 2000 at 12:48:24PM +0200, Jeroen Ruigrok van der Werven wrote: >>> And I and many are strongly for it. It certainly would help us to UTSL >>> and not make stupid replies to commit messages because the source hasn't >>> made it locally yet and thus people haven't read the diffs. >> >>I agree. I'm a victim (?) of making stupid comments recently based >>on commit messages rather than source diffs. > >An alternative viewpoint is that the commit messages should be >adequate to explain the change without reference to the source. Unless they contain the diff they will never *quite* be adequate for all uses, and in general I would prefer not to have commit messages be verbose enough to reach that target. One diff is worth at least DEV_BSIZE words :-) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD coreteam member | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message