From owner-freebsd-acpi@FreeBSD.ORG  Fri Apr 14 07:53:52 2006
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
X-Original-To: acpi@freebsd.org
Delivered-To: freebsd-acpi@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C502916A402;
	Fri, 14 Apr 2006 07:53:52 +0000 (UTC) (envelope-from nate@root.org)
Received: from ylpvm01.prodigy.net (ylpvm01-ext.prodigy.net [207.115.57.32])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 60D9E43D53;
	Fri, 14 Apr 2006 07:53:52 +0000 (GMT) (envelope-from nate@root.org)
Received: from pimout6-ext.prodigy.net (pimout6-int.prodigy.net [207.115.4.22])
	by ylpvm01.prodigy.net (8.12.10 outbound/8.12.10) with ESMTP id
	k3E7rnag016999; Fri, 14 Apr 2006 03:53:49 -0400
X-ORBL: [71.139.10.13]
Received: from [10.0.5.50] (ppp-71-139-10-13.dsl.snfc21.pacbell.net
	[71.139.10.13])
	by pimout6-ext.prodigy.net (8.13.6 out.dk/8.13.6) with ESMTP id
	k3E7rnnl127696; Fri, 14 Apr 2006 03:53:50 -0400
Message-ID: <443F54DF.3080809@root.org>
Date: Fri, 14 Apr 2006 00:53:03 -0700
From: Nate Lawson <nate@root.org>
User-Agent: Thunderbird 1.5 (Windows/20051201)
MIME-Version: 1.0
To: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
References: <20060408.032151.07645075.iwasaki@jp.FreeBSD.org>	<20060410.215024.32344167.iwasaki@jp.FreeBSD.org>	<443C027B.7050002@root.org>
	<20060413.012156.56054177.iwasaki@jp.FreeBSD.org>
In-Reply-To: <20060413.012156.56054177.iwasaki@jp.FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: acpi@freebsd.org, current@freebsd.org
Subject: Re: CFR: ACPI Dock driver
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Apr 2006 07:53:52 -0000

Mitsuru IWASAKI wrote:
> Hi, Thanks for your comments.  Patches for acpi_dock.c are attached.
> 
> One thing,
> 
>> * There also might be an acpi_GetReference() helper function to use.  (I 
>> think I wrote one)
> 
> Sorry, I can't get this.  Could you point this out in detail?
> 
> Thanks!

I looked and found you use acpi_GetReference() already in acpi_dock.c. 
So no idea what I meant, must have misread something.

One other thing:  you explicitly call _INI.  acpi-ca should be doing 
that for you already, is it not?

-- 
Nate