From owner-cvs-all Tue Sep 10 1:58: 0 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 882E637B41E; Tue, 10 Sep 2002 01:57:45 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4B0143E3B; Tue, 10 Sep 2002 01:57:43 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id SAA11026; Tue, 10 Sep 2002 18:57:41 +1000 Date: Tue, 10 Sep 2002 19:05:25 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Jon Mini Cc: Juli Mallett , John Baldwin , , Subject: Re: cvs commit: src/lib/libc/gen siglist.c In-Reply-To: <20020910031104.GA39524@elvis.mu.org> Message-ID: <20020910185546.T596-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 9 Sep 2002, Jon Mini wrote: > Juli Mallett [jmallett@FreeBSD.org] wrote : > > > * De: John Baldwin [ Data: 2002-09-09 ] > > [ Subjecte: RE: cvs commit: src/lib/libc/gen siglist.c ] > > > > > > On 07-Sep-2002 Juli Mallett wrote: > > > > jmallett 2002/09/07 01:14:19 PDT > > > > > > > > Modified files: > > > > lib/libc/gen siglist.c > > > > Log: > > > > Two arrays were born from the same seeds, both grew into complementary sets > > > > of pointers to strings. These two arrays were fixed to the same size, but one > > > > had an implicit zeroed trailer element, which was unused because the size was > > > > used up by the ones before said zeroed trailer element. So the unused limb was > > > > chopped off the over-sized-but-not-over-sized array, and everyone lived happily > > > > ever after. > > > > > > What does this mean in practical terms? > > > > I removed a comma. > > *HAHAHAHAHAHAHAHAHAHAHAHA* I would have worded the log message a little differently: Add a style bug to the declaration of sys_signame[] to make it bug for bug compatible with the declaration of sys_siglist[] :-). (The declaration of sys_signame[] used the technique of having an unnecessary comma at the end of the list to make the list easier to extend, but the declaration of sys_siglist[] didn't. IMO, not using this comma is a style bug except for the small set of array initializers that will never be extended. BTW, C99 fixed the corresponding design-style bug for enums -- C99 code can use this comma at the end of enum lists.) Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message