From owner-svn-src-projects@FreeBSD.ORG Mon Jan 12 21:25:13 2015 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3BE96C7A for ; Mon, 12 Jan 2015 21:25:13 +0000 (UTC) Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 10772F31 for ; Mon, 12 Jan 2015 21:25:11 +0000 (UTC) Received: by mail-pa0-f45.google.com with SMTP id lf10so34278591pab.4 for ; Mon, 12 Jan 2015 13:25:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=+ioS4dlgmug2VHxzkanPldX8Cb3uK+UbByDXJbP3qHQ=; b=ELVMWDUVlIO0jAoUY8HslW4+s2AW+xRR6Vtwu0EIKLKkEK32jT5lZ1F0J0Gb34Lg+L Vdqm78yRTIQbCR65lHFItefvvkaQirzgMVmx5gkZgQJJJTB1kHIsMxJuVYnaFKXU+M94 S4EWMl8B8aPntbhM/WbJWC08qV+OhnPQjlkGeiXS1WLGbzVeGqdmMaXGGBf36EnIHms7 RWgSZX5yqo3YdX6k36/i7CPXDWa07vtzXoIyKC7EPG4nU6FHy/L4WahEVimTSN+BZdoA w8I9Gi4qoF4Zv7x38D+WkXcftQeKSj/x46hQQwgSxL9FrchMRjUFIN0U5/4K7ButVzkG vXDw== X-Gm-Message-State: ALoCoQngggnkpMal3yL9v+YMKSA5AAdeqPuQXfLU+6Jh+WhJLswl7v4qZ2eelFHy+YL/U/cmP0VO MIME-Version: 1.0 X-Received: by 10.66.175.205 with SMTP id cc13mr46983469pac.14.1421097905626; Mon, 12 Jan 2015 13:25:05 -0800 (PST) Sender: andy@fud.org.nz Received: by 10.70.100.33 with HTTP; Mon, 12 Jan 2015 13:25:05 -0800 (PST) In-Reply-To: <201501121353.t0CDreu1022405@svn.freebsd.org> References: <201501121353.t0CDreu1022405@svn.freebsd.org> Date: Tue, 13 Jan 2015 10:25:05 +1300 X-Google-Sender-Auth: tu6-1Fqb3PT8lnGPZr_Hjm_GFz4 Message-ID: Subject: Re: svn commit: r277071 - projects/ifnet/sys/sys From: Andrew Thompson To: Gleb Smirnoff Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: svn-src-projects@freebsd.org, "src-committers@freebsd.org" X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jan 2015 21:25:13 -0000 On 13 January 2015 at 02:53, Gleb Smirnoff wrote: > Author: glebius > Date: Mon Jan 12 13:53:40 2015 > New Revision: 277071 > URL: https://svnweb.freebsd.org/changeset/base/277071 > > Log: > Provide struct mbufq, a STAILQ of mbufs, with counter for packets > and maximum limit set. The structure is supposed to have external > locking. The aim of new structure is to substitute struct ifqueue > in several places in the kernel, where struct ifqueue is used > outside of ifnet code itself. > > Modified: > projects/ifnet/sys/sys/mbuf.h > > Modified: projects/ifnet/sys/sys/mbuf.h > > ============================================================================== > > +static inline int > +mbufq_enqueue(struct mbufq *mq, struct mbuf *m) > +{ > + > + if (mbufq_full(mq)) > + return (ENOBUFS); > + STAILQ_INSERT_TAIL(&mq->mq_head, m, m_stailqpkt); > + mq->mq_len++; > + return (0); > +} > > > +static inline void > +mbufq_prepend(struct mbufq *mq, struct mbuf *m) > +{ > + > + STAILQ_INSERT_HEAD(&mq->mq_head, m, m_stailqpkt); > + mq->mq_len++; > +} > Should this have a full check like mbufq_enqueue? Andrew