From owner-cvs-src@FreeBSD.ORG Fri Nov 21 17:11:08 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6316C16A4CE; Fri, 21 Nov 2003 17:11:08 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D7F2D43FE9; Fri, 21 Nov 2003 17:11:07 -0800 (PST) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id hAM1B7XJ034755; Fri, 21 Nov 2003 17:11:07 -0800 (PST) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.9/8.12.9/Submit) id hAM1B743034754; Fri, 21 Nov 2003 17:11:07 -0800 (PST) (envelope-from peter) Message-Id: <200311220111.hAM1B743034754@repoman.freebsd.org> From: Peter Wemm Date: Fri, 21 Nov 2003 17:11:07 -0800 (PST) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 amd64_mem.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Nov 2003 01:11:08 -0000 peter 2003/11/21 17:11:07 PST FreeBSD src repository Modified files: sys/amd64/amd64 amd64_mem.c Log: Argh! The Athlon64 and Opteron only implement 40 bits of address space in the MTRR Base/Mask registers. If you use the documented algorithm in the systems programming guide, you'll get a GPF. The only thing that has prevented this so far is that the bios pre-sets some MTRR entries which we mis-interpreted sufficiently to fool the memcontrol interface into thinking all the address space was taken and therefore rejected XFree86's requests. However, not all bioses do this.. You get an insta-panic in that case. Grrr. A better fix (dynamic mask) will happen by 5.3/5-stable so that we automatically adapt to more than 40 physical bits. Approved by: re (scottl) Revision Changes Path 1.23 +4 -5 src/sys/amd64/amd64/amd64_mem.c