From owner-freebsd-bugs@FreeBSD.ORG Fri Jul 8 14:10:15 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F1DB416A41F for ; Fri, 8 Jul 2005 14:10:15 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9AE9B43D58 for ; Fri, 8 Jul 2005 14:10:15 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j68EAFQI092805 for ; Fri, 8 Jul 2005 14:10:15 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j68EAEQI092804; Fri, 8 Jul 2005 14:10:14 GMT (envelope-from gnats) Date: Fri, 8 Jul 2005 14:10:14 GMT Message-Id: <200507081410.j68EAEQI092804@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Yuriy N. Shkandybin" Cc: Subject: Re: kern/83011: nge vlans broken X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Yuriy N. Shkandybin" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2005 14:10:16 -0000 The following reply was made to PR kern/83011; it has been noted by GNATS. From: "Yuriy N. Shkandybin" To: , "Yuriy N. Shkandybin" Cc: Subject: Re: kern/83011: nge vlans broken Date: Fri, 8 Jul 2005 17:58:58 +0400 I've invistigated that m_head mbuf doesn't have M_VLANTAG when performing VLAN_OUTPUT() next diff for /usr/src/sys/net/if_vlan_var.h make it work: --- 1.h Fri Jul 8 17:34:31 2005 +++ if_vlan_var.h Fri Jul 8 17:35:53 2005 @@ -111,7 +111,7 @@ } while (0) #define VLAN_OUTPUT_TAG(_ifp, _m) \ - ((_m)->m_flags & M_VLANTAG ? \ + ((_ifp)->if_nvlans != 0 ? \ m_tag_locate((_m), MTAG_VLAN, MTAG_VLAN_TAG, NULL) : NULL) #define VLAN_TAG_VALUE(_mt) (*(u_int *)((_mt)+1)) #endif /* _KERNEL */ Actually this is partial backout ru@ commit http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/net/if_vlan_var.h.diff?r1=1.20&r2=1.21&f=h Since it's not adressed to if_nge itself, so it's possible same problems for another interfaces. Jura