From owner-svn-ports-all@freebsd.org Mon May 14 10:56:48 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C767FFE7466; Mon, 14 May 2018 10:56:48 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6D27F7A3D0; Mon, 14 May 2018 10:56:48 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id C1A502213E; Mon, 14 May 2018 06:56:47 -0400 (EDT) Received: from web6 ([10.202.2.216]) by compute4.internal (MEProxy); Mon, 14 May 2018 06:56:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=FsCpjj SHqt7ZMelBvLOwdAj++5gthAEQr/XWi/3/vb4=; b=PYYxN0AezU71qYwv+pMIkC bmdM5AHzZjkj0VrDgJZRn1MsEUHnAhfKjpth3ZOhPq5eD8dxzDfXK/XaWbIoRox1 s8Tj6NlZUpUqFF07MjIvR589LCysjSEq14fMl/G/pAemYvaxvtX+yxEDS2mCyY6k 0jNWm5SVhDkunIQoPowb+aHhd8I0e5PUNqebzyeZr7lebEXnA1JuTyr/rNwtZNj4 AtoH4rrEBMNoYZjk6vZR/4xu9AM5MRSexx2yyVD9gaIN7SwPXkjx1X0YjEyvFvdK UkEwyNL5v/QDsXOIF8PVFFkoi37lHXp7Gx80AzXOqP3KIPbJO3ihtWxElOok2hxQ == X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id 72F13425A; Mon, 14 May 2018 06:56:47 -0400 (EDT) Message-Id: <1526295407.2311419.1371181224.2C509C6F@webmail.messagingengine.com> From: Tobias Kortkamp To: Raphael Kubo da Costa , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-29fe4c42 In-Reply-To: <201805141024.w4EAONGN032356@repo.freebsd.org> Subject: Re: svn commit: r469874 - head/x11-fonts/fantasque-sans-mono Date: Mon, 14 May 2018 12:56:47 +0200 References: <201805141024.w4EAONGN032356@repo.freebsd.org> X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2018 10:56:49 -0000 On Mon, May 14, 2018, at 12:24, Raphael Kubo da Costa wrote: > Author: rakuco > Date: Mon May 14 10:24:23 2018 > New Revision: 469874 > URL: https://svnweb.freebsd.org/changeset/ports/469874 > > Log: > Add options to install variants. > > Fantasque Sans Mono distribution site has variants aside from the standard > version. Add options to allow installing those variants. > > PR: 228206 > Submitted by: Jonathan Chen > > Modified: > head/x11-fonts/fantasque-sans-mono/Makefile > head/x11-fonts/fantasque-sans-mono/distinfo > > Modified: head/x11-fonts/fantasque-sans-mono/Makefile > ============================================================================== > --- head/x11-fonts/fantasque-sans-mono/Makefile Mon May 14 10:02:38 2018 (r469873) > +++ head/x11-fonts/fantasque-sans-mono/Makefile Mon May 14 10:24:23 2018 (r469874) > @@ -2,9 +2,13 @@ > > PORTNAME= fantasque-sans-mono > PORTVERSION= 1.7.2 > +PORTREVISION= 1 > CATEGORIES= x11-fonts > MASTER_SITES= > https://github.com/belluzj/fantasque-sans/releases/download/v$ > {PORTVERSION}/ > -DISTNAME= FantasqueSansMono-Normal > +DISTFILES= FantasqueSansMono-Normal.tar.gz \ > + FantasqueSansMono-NoLoopK.tar.gz \ > + FantasqueSansMono-LargeLineHeight.tar.gz \ > + FantasqueSansMono-LargeLineHeight-NoLoopK.tar.gz > > MAINTAINER= rakuco@FreeBSD.org > COMMENT= Programming font, designed with functionality in mind > @@ -17,6 +21,21 @@ NO_WRKSUBDIR= yes > USES= fonts > > OPTIONS_DEFINE= DOCS > + > +OPTIONS_SINGLE= VARIANT > +OPTIONS_SINGLE_VARIANT= NORMAL NOLOOPK LLINE LLINENOLOOPK > + > +NORMAL_DESC= Standard > +NOLOOPK_DESC= Nondescript K > +LLINE_DESC= Large line spacing > +LLINENOLOOPK_DESC= Large line spacing with Nondescript K > + > +OPTIONS_DEFAULT= NORMAL > + > +NORMAL_EXTRACT_ONLY= FantasqueSansMono-Normal.tar.gz > +NOLOOPK_EXTRACT_ONLY= FantasqueSansMono-NoLoopK.tar.gz > +LLINE_EXTRACT_ONLY= FantasqueSansMono-LargeLineHeight.tar.gz > +LLINENOLOOPK_EXTRACT_ONLY= FantasqueSansMono-LargeLineHeight-NoLoopK.tar.gz Why do I have to download all variants when only one distfile is ever be used for each one? Why not use something like NORMAL_DISTFILES=FantasqueSansMono-Normal.tar.gz or NORMAL_VARS=DISTNAME=FantasqueSansMono-Normal instead of the _EXTRACT_ONLY helpers?