From owner-svn-src-all@FreeBSD.ORG  Tue Apr 21 19:43:08 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D56AE106564A;
	Tue, 21 Apr 2009 19:43:08 +0000 (UTC) (envelope-from das@FreeBSD.ORG)
Received: from zim.MIT.EDU (ZIM.MIT.EDU [18.95.3.101])
	by mx1.freebsd.org (Postfix) with ESMTP id 904678FC14;
	Tue, 21 Apr 2009 19:43:08 +0000 (UTC) (envelope-from das@FreeBSD.ORG)
Received: from zim.MIT.EDU (localhost [127.0.0.1])
	by zim.MIT.EDU (8.14.3/8.14.2) with ESMTP id n3LJkM8j019253;
	Tue, 21 Apr 2009 15:46:22 -0400 (EDT) (envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by zim.MIT.EDU (8.14.3/8.14.2/Submit) id n3LJkMXF019252;
	Tue, 21 Apr 2009 15:46:22 -0400 (EDT) (envelope-from das@FreeBSD.ORG)
Date: Tue, 21 Apr 2009 15:46:22 -0400
From: David Schultz <das@FreeBSD.ORG>
To: Roman Divacky <rdivacky@FreeBSD.ORG>
Message-ID: <20090421194622.GA19215@zim.MIT.EDU>
Mail-Followup-To: Roman Divacky <rdivacky@FreeBSD.ORG>,
	src-committers@FreeBSD.ORG, svn-src-all@FreeBSD.ORG,
	svn-src-head@FreeBSD.ORG
References: <200904201819.n3KIJcZo054306@svn.freebsd.org>
	<20090421185436.GA18628@zim.MIT.EDU>
	<20090421190651.GA2505@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090421190651.GA2505@freebsd.org>
Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG,
	src-committers@FreeBSD.ORG
Subject: Re: svn commit: r191330 - head/usr.bin/ncal
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Apr 2009 19:43:09 -0000

On Tue, Apr 21, 2009, Roman Divacky wrote:
> > Also, before this change, ncal was already full of convoluted
> > buffer handling, arbitrary buffer sizes, and little to no bounds
> > checking. This commit adds more magic numbers and fragile buffer
> > handling code, and generally makes an already hairy program even
> > less scrutable. This isn't your fault, but it would be nice if we
> > could make ncal better before it gets much worse. For instance,
> > you might use snprintf() or asprintf() instead of an extra half
> > dozen calls to memcpy() with various offsets.
> 
> yes, thats true. do you want me to revert this? I am perfectly fine
> with having locally modified cal that supports this highlighting
> and not share this with world at all.

I don't care (although some other people on this thread seem to);
I'm just encouraging you to clean things up a little before making
the code even less maintainable.