From owner-svn-src-stable@freebsd.org  Tue Sep  4 16:50:13 2018
Return-Path: <owner-svn-src-stable@freebsd.org>
Delivered-To: svn-src-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 57656FF4E88;
 Tue,  4 Sep 2018 16:50:13 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 03E4076EE5;
 Tue,  4 Sep 2018 16:50:13 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx
 [66.234.199.215])
 by mail.baldwin.cx (Postfix) with ESMTPSA id 62EFA10B476;
 Tue,  4 Sep 2018 12:50:11 -0400 (EDT)
Subject: Re: svn commit: r338451 - stable/11/usr.bin/last
To: araujo@freebsd.org, src-committers <src-committers@freebsd.org>,
 svn-src-all@freebsd.org, svn-src-stable@freebsd.org,
 svn-src-stable-11@freebsd.org
References: <201809040953.w849rj4j082295@repo.freebsd.org>
 <CAOfEmZhjP5Va8zuUfN4PP-Vdnp0E56S2m0Sa4uUTLnOSmj-PkA@mail.gmail.com>
 <20180904100934.GC27236@rincewind.trouble.is>
From: John Baldwin <jhb@FreeBSD.org>
Message-ID: <3781df8e-57a0-feb8-9c6a-83a3a760e0d3@FreeBSD.org>
Date: Tue, 4 Sep 2018 09:39:40 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180904100934.GC27236@rincewind.trouble.is>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Tue, 04 Sep 2018 12:50:12 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: svn-src-stable@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for all the -stable branches of the src tree
 <svn-src-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-stable>, 
 <mailto:svn-src-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable/>
List-Post: <mailto:svn-src-stable@freebsd.org>
List-Help: <mailto:svn-src-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-stable>,
 <mailto:svn-src-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Sep 2018 16:50:13 -0000

On 9/4/18 3:09 AM, Philip Paeps wrote:
> On 2018-09-04 17:59:30 (+0800), Marcelo Araujo wrote:
>> 2018-09-04 17:53 GMT+08:00 Philip Paeps <philip@freebsd.org>:
>>
>>> Author: philip
>>> Date: Tue Sep  4 09:53:45 2018
>>> New Revision: 338451
>>> URL: https://svnweb.freebsd.org/changeset/base/338451
>>>
>>> Log:
>>>   MFC r319508:
>>>     Fix a memory leak with last
>>>     free memory allocated to 'buf'
>>
>> Is that the right patch? Or the commit message missed adding support to 
>> libxo(3)?
> 
> I merged two changes:
> 
> * r319508 plugs a memory leak.  This was originally committed by stevek 
> in June 2017 but apparently never MFCed.
> 
> * rr338352 adds libxo support.
> 
> I mentioned both changes in the commit message.  I'm not sure what's 
> unclear.

Most MFC commits list a summary of merged changes first (and perhaps
a brief summary of the effective MFC if it is using several commits from
HEAD to merge a single feature) before including logs from individual
changes.  This ensures that the first line of a commit is still a useful
overall summary of the entire change.

-- 
John Baldwin