From owner-freebsd-fs@freebsd.org  Wed Dec  5 18:45:38 2018
Return-Path: <owner-freebsd-fs@freebsd.org>
Delivered-To: freebsd-fs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 092AD1323F6A
 for <freebsd-fs@mailman.ysv.freebsd.org>; Wed,  5 Dec 2018 18:45:38 +0000 (UTC)
 (envelope-from truckman@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A32FB82DD9;
 Wed,  5 Dec 2018 18:45:37 +0000 (UTC)
 (envelope-from truckman@FreeBSD.org)
Received: from mousie.catspoiler.org (unknown [76.212.85.177])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 (Authenticated sender: truckman)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 089AC249C9;
 Wed,  5 Dec 2018 18:45:36 +0000 (UTC)
 (envelope-from truckman@FreeBSD.org)
Date: Wed, 5 Dec 2018 10:45:35 -0800 (PST)
From: Don Lewis <truckman@FreeBSD.org>
Subject: Re: stuck with ufs CHECK-HASH errors
To: Kirk McKusick <mckusick@mckusick.com>
cc: freebsd-fs@FreeBSD.org
In-Reply-To: <201812050644.wB56iYQQ020650@chez.mckusick.com>
Message-ID: <tkrat.e3d9bb21ca501329@FreeBSD.org>
References: <tkrat.2f594d1b2546d371@FreeBSD.org>
 <201812050644.wB56iYQQ020650@chez.mckusick.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; CHARSET=us-ascii
Content-Disposition: INLINE
X-Rspamd-Queue-Id: A32FB82DD9
X-Spamd-Result: default: False [-1.12 / 15.00];
 local_wl_from(0.00)[FreeBSD.org];
 NEURAL_HAM_MEDIUM(-0.76)[-0.758,0];
 NEURAL_SPAM_SHORT(0.25)[0.248,0];
 NEURAL_HAM_LONG(-0.61)[-0.612,0];
 ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US]
X-Rspamd-Server: mx1.freebsd.org
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs/>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Dec 2018 18:45:38 -0000

On  4 Dec, Kirk McKusick wrote:
>> Date: Mon, 3 Dec 2018 23:08:50 -0800 (PST)
>> From: Don Lewis <truckman@FreeBSD.org>
>> Subject: Re: stuck with ufs CHECK-HASH errors
>> To: Kirk McKusick <mckusick@mckusick.com>
>> cc: freebsd-fs@FreeBSD.org
>> 
>> On  3 Dec, Kirk McKusick wrote:
>>> I am working on a fix. Hopefully have it in no more than a day.
>> 
>> I figured out that ufs_disk_fillout() and therefore sbread() in libufs
>> is never getting called.  Therefore the superblock used by cgput() is
>> all zeros.  If I change the call to ufs_disk_fillout_blank() in setup()
>> to ufs_disk_fillout() then things appear to work much better.
> 
> Your above workaround was quite helpful in tracking down the
> problem and coming up with an appropriate fix that did not
> conflict with the superblock check-hashes. I have checked
> in a fix (-r341510). Please confirm that it resolves your
> problem.

Thanks!  It worked on my broken VM.