From owner-svn-ports-head@freebsd.org Mon Aug 21 13:55:20 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 08C51DDD188; Mon, 21 Aug 2017 13:55:20 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-it0-x22e.google.com (mail-it0-x22e.google.com [IPv6:2607:f8b0:4001:c0b::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C2B7B70E07; Mon, 21 Aug 2017 13:55:19 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: by mail-it0-x22e.google.com with SMTP id x187so10844481ite.1; Mon, 21 Aug 2017 06:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=kvlZYuIIAQTwh1CWmFjBrac2vEZVsIL+ny7gHy7SlvM=; b=eIbukVr6DuQahJqKfvUoSlWo+cu9PfJQ2sxXg6iEoSabAqzTDZY5OluB8i/X68u0wt YsHx/7rhdrAYdx2bxNmkLivu6CUYuj35XQh3nX7pTB9PjbqaIiYKi2aG7dxyuZQqNWLC hTVlv/3qgEQiEb5yWV/jj3fR7veWt1V0zUXuMYgVlG7tSIXqZmnXgj9894b9dR3dZZSi UJmMUgoEHBbUQ9arSNwX+KkIp/kf3K0OtmXHyg8y1dDiIB37VOCjpK3XtPUxlTONziIG QMHS64ItcozmKsYp3CdQHZsmRKnzmssSFT8foC4xGBCUvybx6Lhn9rJk4t7l5mWX10F5 RFWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=kvlZYuIIAQTwh1CWmFjBrac2vEZVsIL+ny7gHy7SlvM=; b=omCawmTH5VOow1yWAlLdrt+06YwTR5YQbThtSudYfcytrEQXq3dzW69/jPNa9YvRqk B4n4c0z5FsIkf7G4NAASPoX0LcULAASRsW+nQVnuYtfNhbHKwkW/PhkBYIIJ1Dm32dHV RLsAoFmpLmB+r6WzAYlpYZ61j8yq5Dni4NMuUhgSLy4MapYZ3Qvn46XriBbGy+oi8LH+ 12Ob9iJOr1egSzmKkkdmHfqWhVZG/282w9113grD7Q9ZNG4WgzFAVTZOyg3tIfsyIjHH d5jDgfTwdI6td38nVy9APS6CVPYyxW52jna7i3pEkQgQ53Hd8G59DSN7lD/e5G2RsEn2 8nrw== X-Gm-Message-State: AHYfb5j+UmBGsb9bzT7Jc80VFjlxPO4doRFx6gRyFQq1dvwqXiyGr+q1 WlBb2CV5ictSmv3H03DzpHurDoLfmw== X-Received: by 10.36.119.3 with SMTP id g3mr206239itc.177.1503323719009; Mon, 21 Aug 2017 06:55:19 -0700 (PDT) MIME-Version: 1.0 Sender: antoine.brodin.freebsd@gmail.com Received: by 10.107.128.138 with HTTP; Mon, 21 Aug 2017 06:55:18 -0700 (PDT) In-Reply-To: References: <201708211326.v7LDQTpS021179@repo.freebsd.org> From: Antoine Brodin Date: Mon, 21 Aug 2017 13:55:18 +0000 X-Google-Sender-Auth: qbzxY8G8X3-1XxaefSwkpbBgUBA Message-ID: Subject: Re: svn commit: r448472 - in head: Mk/Uses archivers/freetar archivers/unarchiver archivers/zipper audio/cddb-bundle audio/gnustep-cdplayer audio/mpdcon biology/biococoa databases/fortytwo-bdb database... To: David Chisnall Cc: "ports-committers@freebsd.org" , "svn-ports-all@freebsd.org" , "svn-ports-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2017 13:55:20 -0000 On Mon, Aug 21, 2017 at 1:42 PM, Antoine Brodin wrote: > On Mon, Aug 21, 2017 at 1:26 PM, David Chisnall wrote: >> Author: theraven >> Date: Mon Aug 21 13:26:28 2017 >> New Revision: 448472 >> URL: https://svnweb.freebsd.org/changeset/ports/448472 >> >> Log: >> Update GNUstep core libraries. >> >> Update the default Objective-C compiler. >> >> Fix various build failures in GNUstep ports from newer versions of the GNUstep >> core libraries and from changes to GNUstep Make. >> >> Update various ports that use GNUstep and bump the portrevision of the ones >> that haven't had a new release. > ... >> Modified: head/Mk/Uses/objc.mk >> ============================================================================== >> --- head/Mk/Uses/objc.mk Mon Aug 21 13:14:02 2017 (r448471) >> +++ head/Mk/Uses/objc.mk Mon Aug 21 13:26:28 2017 (r448472) > ... >> -# We do always need clang >> -.if ${COMPILER_TYPE} != clang >> -.if ${ALT_COMPILER_TYPE} == clang >> +# We do always need clang and prefer a recent version >> +.if (${COMPILER_TYPE} == clang && ${COMPILER_VERSION} < ${OBJC_CLANG_VERSION}) || ${COMPILER_TYPE} != clang > > Hi, > > The condition for the compiler version seems reversed? I misread the double-if. Cheers, Antoine