From owner-freebsd-hardware@FreeBSD.ORG Fri Jan 18 17:39:23 2013 Return-Path: Delivered-To: freebsd-hardware@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 8FC535D1; Fri, 18 Jan 2013 17:39:23 +0000 (UTC) (envelope-from Andre.Albsmeier@siemens.com) Received: from thoth.sbs.de (thoth.sbs.de [192.35.17.2]) by mx1.freebsd.org (Postfix) with ESMTP id 29645B3D; Fri, 18 Jan 2013 17:39:22 +0000 (UTC) Received: from mail1.siemens.de (localhost [127.0.0.1]) by thoth.sbs.de (8.13.6/8.13.6) with ESMTP id r0IHdFtg010370; Fri, 18 Jan 2013 18:39:15 +0100 Received: from curry.mchp.siemens.de (curry.mchp.siemens.de [139.25.40.130]) by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id r0IHdFNd010923; Fri, 18 Jan 2013 18:39:15 +0100 Received: (from localhost) by curry.mchp.siemens.de (8.14.5/8.14.5) id r0IHdFMb070720; Date: Fri, 18 Jan 2013 18:39:14 +0100 From: Andre Albsmeier To: John Baldwin Subject: Re: ppc fails to attach to puc on 9.1-STABLE, 7.4-STABLE works Message-ID: <20130118173914.GA93921@bali> References: <20130110074052.GA8922@bali> <201301171337.56851.jhb@freebsd.org> <20130118184242.Q1470@besplex.bde.org> <201301181158.50048.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201301181158.50048.jhb@freebsd.org> X-Echelon: X-Advice: Drop that crappy M$-Outlook, I'm tired of your viruses! User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "freebsd-hardware@freebsd.org" X-BeenThere: freebsd-hardware@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: General discussion of FreeBSD hardware List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2013 17:39:23 -0000 On Fri, 18-Jan-2013 at 17:58:49 +0100, John Baldwin wrote: > On Friday, January 18, 2013 3:05:53 am Bruce Evans wrote: > > On Thu, 17 Jan 2013, John Baldwin wrote: > > > > > On Wednesday, January 16, 2013 10:10:34 pm Bruce Evans wrote: > > >> On Wed, 16 Jan 2013, Andre Albsmeier wrote: > > >> > > >>> On Tue, 15-Jan-2013 at 21:27:07 +0100, John Baldwin wrote: > > > > >>>>> [reading flags in the driver] > > >>>> This should not be needed for "flags". Look for 'devflags' in > > >>>> sys/kern/subr_bus.c. The kernel always reads the current 'flags' hint during > > >>>> device probe and stores them in dev->devflags and leaves them there after a > > >>>> successful probe (so they should be seen by attach). Specifically, note: > > >>>> > > >>>> /* Set the winning driver, devclass, and flags. */ > > >> > > >> So the flags interface is unusable before some driver "wins". > > > > > > No, we set it twice. Specifically, it is set before each probe, then it is > > > set again after a winning driver is chosen so that the proper flags exist > > > during attach as well. > > > > Why didn't it work for Andre then? > > In followup e-mail he said it did work. The one reason it might not have > worked before is that if he did 'ppc.0.at=foo' and that forced the ppc device > to be ppc1 instead of ppc0 in which case the ppc0 flags wouldn't have applied. Well, in my despair (before the bug was fixed) I tried also (and only): hint.ppc.1.flags=0x2F but this didn't work as well. If we want to dig into this, I can plug another puc card in my desktop box (the other one is sitting in a server where I don't want to do experiments) and try to reproduce it here... -Andre > > > It might be a layering problem, with the flags not working because the > > hint says that they are for ppc but the bus name being puc. I thought > > that this problem was fixed. In FreeBSD-~5.2, I had to add flags > > reading to sio_pci.c and sio_puc.c to get flags for sio actually seen > > by sio when the bus is not isa. subr_bus.c does the 2 settings of the > > flags much the same in FreeBSD-~5.2, but this certainly doesn't work. > > I don't know off hand. :( > > -- > John Baldwin -- In a world without walls and fences, who needs windows and gates?