From owner-freebsd-current@freebsd.org Thu Jul 30 17:08:36 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DCFD09AF4A7 for ; Thu, 30 Jul 2015 17:08:36 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from mail.strugglingcoder.info (strugglingcoder.info [65.19.130.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CBC04A32; Thu, 30 Jul 2015 17:08:36 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from localhost (unknown [10.1.1.3]) (Authenticated sender: hiren@strugglingcoder.info) by mail.strugglingcoder.info (Postfix) with ESMTPSA id 946B6D3D8A; Thu, 30 Jul 2015 10:00:35 -0700 (PDT) Date: Thu, 30 Jul 2015 10:00:35 -0700 From: hiren panchasara To: Hans Petter Selasky Cc: FreeBSD Current , Sean Bruno , erj@FreeBSD.org Subject: Re: E1000 mbuf leaks Message-ID: <20150730170035.GE39365@strugglingcoder.info> References: <55B60FC8.2020003@selasky.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+ts6NCQ4mrNQIV8p" Content-Disposition: inline In-Reply-To: <55B60FC8.2020003@selasky.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2015 17:08:37 -0000 --+ts6NCQ4mrNQIV8p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 07/27/15 at 01:02P, Hans Petter Selasky wrote: > Hi, >=20 > I'm currently doing some busdma work, and possibly stepped over some=20 > driver bugs. When "bus_dmamap_load_mbuf_sg()" returns ENOMEM the mbuf=20 > chain is not freed. Is there some magic in "bus_dmamap_load_mbuf_sg()"=20 > for that error code or is there a possible memory leak in all E1000=20 > drivers? See attached patch. Can you open a phabricator review if this hasn't been reviewed/committed yet? cheers, Hiren --+ts6NCQ4mrNQIV8p Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQF8BAEBCgBmBQJVulgyXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lTMAH/3BAU5raOMXt5iisRT0cMb4f M0wCVHWiTSJd9PvCfKHN7ArKKl3Wwnob85g2VeIdopzgtq0kAdc2HbbxTS2ElzeD 8Dsh1CyzIwSoOyEYG2+UbG6a4jJWXdoTZub1M675fbzxXFMXlLQJhIY0ehlg3T0Z ELFFMD0/ESrO5fuJSkGhi2BX7ofgIftTgf5PJ6qrKlmExBl6cYRgC+Qd0V+o8rro Rm1dA4UMVW4Hp370iKXH3h4q4rfSzNfUeq6/HjHYkvQXR+GtgjJ4/QhdaOVfR1W1 eDbPU5dyMaoZQUvbQFf/bX9D7ZwW1Do8urjk7yWH/mjx05Sbv+k515TnjHm3bKE= =Hg0Y -----END PGP SIGNATURE----- --+ts6NCQ4mrNQIV8p--