From owner-svn-src-all@FreeBSD.ORG  Wed Jun 16 14:13:57 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E28D1106567C;
	Wed, 16 Jun 2010 14:13:57 +0000 (UTC)
	(envelope-from raj@semihalf.com)
Received: from smtp.semihalf.com (smtp.semihalf.com [213.17.239.109])
	by mx1.freebsd.org (Postfix) with ESMTP id 8B2418FC1F;
	Wed, 16 Jun 2010 14:13:57 +0000 (UTC)
Received: from localhost (unknown [213.17.239.109])
	by smtp.semihalf.com (Postfix) with ESMTP id D98E8C42DB;
	Wed, 16 Jun 2010 16:19:17 +0200 (CEST)
X-Virus-Scanned: by amavisd-new at semihalf.com
Received: from smtp.semihalf.com ([213.17.239.109])
	by localhost (smtp.semihalf.com [213.17.239.109]) (amavisd-new,
	port 10024)
	with ESMTP id 6FUq8JWVi5ae; Wed, 16 Jun 2010 16:19:17 +0200 (CEST)
Received: from [10.0.0.79] (cardhu.semihalf.com [213.17.239.108])
	by smtp.semihalf.com (Postfix) with ESMTPSA id 4DF7FC42E1;
	Wed, 16 Jun 2010 16:19:17 +0200 (CEST)
Mime-Version: 1.0 (Apple Message framework v1078)
Content-Type: text/plain; charset=us-ascii
From: Rafal Jaworowski <raj@semihalf.com>
In-Reply-To: <20100616210344.47209ff2@bender>
Date: Wed, 16 Jun 2010 16:13:55 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <B3697DEE-6BB0-45D0-8B01-B8809600C238@semihalf.com>
References: <201006131308.o5DD8NTA033564@svn.freebsd.org>
	<20100616210344.47209ff2@bender>
To: Andrew Turner <andrew@fubar.geek.nz>
X-Mailer: Apple Mail (2.1078)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r209129 - head/sys/arm/arm
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Jun 2010 14:13:58 -0000


On 2010-06-16, at 11:03, Andrew Turner wrote:

> On Sun, 13 Jun 2010 13:08:23 +0000 (UTC)
> Rafal Jaworowski <raj@FreeBSD.org> wrote:
>=20
>> Author: raj
>> Date: Sun Jun 13 13:08:23 2010
>> New Revision: 209129
>> URL: http://svn.freebsd.org/changeset/base/209129
>>=20
>> Log:
>>  Improve style.
>>=20
>> Modified:
>>  head/sys/arm/arm/nexus.c
>>=20
>> Modified: head/sys/arm/arm/nexus.c
>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> --- head/sys/arm/arm/nexus.c	Sun Jun 13 13:02:43 2010
>> (r209128) +++ head/sys/arm/arm/nexus.c	Sun Jun 13 13:08:23
>> 2010	(r209129) @@ -107,6 +107,7 @@ static devclass_t
>> nexus_devclass; static int
>> nexus_probe(device_t dev)
>> {
>> +
>> 	device_quiet(dev);	/* suppress attach message for
>> neatness */=20
>> 	mem_rman.rm_start =3D 0;
>> @@ -116,7 +117,7 @@ nexus_probe(device_t dev)
>> 	if (rman_init(&mem_rman) || rman_manage_region(&mem_rman, 0,
>> ~0u)) panic("nexus_probe mem_rman");
>>=20
>> -	return (0);
>> +	return (BUS_PROBE_DEFAULT);
> Changing the return value of nexus_probe from 0 to BUS_PROBE_DEFAULT
> causes the following panic for me when the s3c24x0 driver calls
> rman_init. The attached patch fixes it by moving the call to rman_init
> from nexus_probe to nexus_attach.

Thanks (and sorry for the breakage -- it wasn't seen on FDT-enabled =
platforms as they use their own rman(s)..), should be fixed in r209232.

Rafal