Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 18 Jan 2009 12:18:09 -0800
From:      Andrew Thompson <thompsa@FreeBSD.org>
To:        Luigi Rizzo <rizzo@iet.unipi.it>
Cc:        Andrew Lankford <lankfordandrew@charter.net>, stable@freebsd.org
Subject:   Re: System borked:  loader stack overflow.
Message-ID:  <20090118201809.GA44812@citylink.fud.org.nz>
In-Reply-To: <20090118200856.GA28366@onelab2.iet.unipi.it>
References:  <49729D80.8010506@charter.net> <20090118093346.GA9819@onelab2.iet.unipi.it> <49734D0B.8050604@charter.net> <20090118164724.GA21705@onelab2.iet.unipi.it> <20090118185605.GA28874@citylink.fud.org.nz> <497380BB.1050409@charter.net> <20090118200856.GA28366@onelab2.iet.unipi.it>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 18, 2009 at 09:08:56PM +0100, Luigi Rizzo wrote:
> On Sun, Jan 18, 2009 at 02:19:23PM -0500, Andrew Lankford wrote:
> > Andrew Thompson wrote:
> ...
> > >Having the following in /boot/loader.conf triggers it for me,
> > >
> > > loader_conf_files="/boot/device.hints /boot/loader.conf"
> > >
> > >You may say thats its an invalid config line but the loader shouldnt
> > >blow up from it. Can this be fixed up somehow?
> 
> no, this cannot be "fixed" because it is the user misprogramming
> the system, such as providing the wrong path to the kernel
> or writing a loop in /etc/rc.conf or a billion other ways.

Yes, but you can copy /etc/defaults/rc.conf to /etc/rc.conf and things
still work.

> Setting loader_conf_files="x y z" is basically equivalent to
> writing "call a; call b; call c;" in a programming language,
> with the only difference that the action is done at the end of
> the current file.

Ok, then loader_conf_files needs to be marked as special and not to be
overridden from /boot/defaults/loader.conf like all the other options.

A better way would be to track included files and not reprocess them.

Also an entry in UPDATING that a config error that was once harmless now
renders the system unbootable (without intervention).


cheers,
Andrew



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090118201809.GA44812>