From owner-freebsd-bugs Fri Jun 28 10: 3:26 2002 Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BF87B37B401 for ; Fri, 28 Jun 2002 10:03:16 -0700 (PDT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B70E43E06 for ; Fri, 28 Jun 2002 10:03:16 -0700 (PDT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (IDENT:brdavis@localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.12.3/8.12.3) with ESMTP id g5SH3Eri028639; Fri, 28 Jun 2002 10:03:14 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.12.3/8.12.3/Submit) id g5SH37SD028630; Fri, 28 Jun 2002 10:03:07 -0700 Date: Fri, 28 Jun 2002 10:03:07 -0700 From: Brooks Davis To: Andy Farkas Cc: Brooks Davis , freebsd-bugs@FreeBSD.ORG, Dan Lukes Subject: Re: bin/39868: cleaning sbin/dump code from warnings Message-ID: <20020628100307.A26852@Odin.AC.HMC.Edu> References: <200206270110.g5R1A4QO001789@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="6c2NcOVqGQ03X4Wi" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from andyf@speednet.com.au on Fri, Jun 28, 2002 at 03:54:31PM +1000 X-Virus-Scanned: by amavisd-milter (http://amavis.org/) on odin.ac.hmc.edu Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --6c2NcOVqGQ03X4Wi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 28, 2002 at 03:54:31PM +1000, Andy Farkas wrote: > On Wed, 26 Jun 2002, Brooks Davis wrote: >=20 > > Thank you for submitting patches to address the warnings in this code. >=20 > I think what Dan is doing is A Good Thing (tm). Absolutly. > > Unfortunatly, you had really bad timing and the code in -current has > > changed significantly due to the changes required for UFS2 support. > > This means it is unlikely these patches will apply to -current. They > > will apply to -stable, but I'm not sure what we want to do about that > > given that there won't be significantly development of file system > > changes in -stable. >=20 > Surely the work Dan has put into these PR's makes it extremely easy for a > committer to review the patches, then commit. >=20 > Even though RELENG_4 is nearing its end of life and developer and > committer time is precious, perhaps if the user community sees results > from their work, more contributions will be made. I was simply pointing out that due to timing problems that are no one's fault, it's going to be hard to use these patches in a timely manner. We don't commit directly to stable without significant cause and in most cases fixing warnings in programs that work isn't. Certaintly I would encourage anyone doing warnings fixes in current to merge these patches as appropriate to both current and stable. For that matter, maybe Dan want's go really get his hands dirty and try current once DP2 comes out in July. It's shaping up pretty nicly IMO. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --6c2NcOVqGQ03X4Wi Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE9HJbKXY6L6fI4GtQRAkLTAJ9gZAMaLaV9HxXVzBHn8vR6FODAkgCfb/WQ k9b4Xcukwn8CuUYdEuiGv8Y= =3W6t -----END PGP SIGNATURE----- --6c2NcOVqGQ03X4Wi-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message