From owner-freebsd-current@FreeBSD.ORG Thu Jun 14 05:54:03 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9C6C116A400 for ; Thu, 14 Jun 2007 05:54:03 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 89FAF13C468 for ; Thu, 14 Jun 2007 05:54:03 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 1D80C1A3C19; Wed, 13 Jun 2007 22:53:37 -0700 (PDT) Received: from rot13.obsecurity.org (rot13.obsecurity.org [192.168.1.5]) by obsecurity.dyndns.org (Postfix) with ESMTP id C5204512A6; Thu, 14 Jun 2007 01:54:02 -0400 (EDT) Received: by rot13.obsecurity.org (Postfix, from userid 1001) id 02A76C261; Thu, 14 Jun 2007 01:54:02 -0400 (EDT) Date: Thu, 14 Jun 2007 01:54:01 -0400 From: Kris Kennaway To: Randall Stewart Message-ID: <20070614055401.GA77538@rot13.obsecurity.org> References: <46706E63.1080906@cisco.com> <20070614022510.GA61989@rot13.obsecurity.org> <4670B1A0.4070706@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4670B1A0.4070706@cisco.com> User-Agent: Mutt/1.4.2.3i Cc: current@freebsd.org, Kris Kennaway Subject: Re: KTR and SCTP X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2007 05:54:03 -0000 On Wed, Jun 13, 2007 at 11:10:24PM -0400, Randall Stewart wrote: > Kris Kennaway wrote: > >On Wed, Jun 13, 2007 at 06:23:31PM -0400, Randall Stewart wrote: > > > >>All: > >> > >>I am in the process of converting all the logging that > >>SCTP does to use the KTR sub-system. This will fit > >>nicely.. I still need to do some things to make it > >>so I can pull out the logs and make pretty charts and > >>graphs (in SCTP its used for debugging but also exploring > >>how CC and other niceties works).. > >> > >>But I was wondering.. would anyone mind if I took > >>KTR_SPARE2 > >> > >>and made it: > >> > >>KTR_SCTP_SUBSYS > >> > >>I have a huge amount of tracing under SCTP now.. so > >>many I am setting in a seperate mask set to enable/disable > >>various pieces of it.. So I was thinking it would > >>warrent a sub-system of its own :-D > >> > >>Any objections? If not I will change it :-D > > > > > >Yeah, we really do need to keep those spare fields for local use. > > > >Kris > > > Ok.. so I will just use > > KTR_SPARE2 > > in my logs then I guess.. :-) You can't use KTR_SPARE* in committed code either, or it's no longer spare :) You should do something like: i.e. do something like #ifdef SCTP_TRACE #define KTR_SCTP KTR_SUBSYS #else #define KTR_SCTP 0 #endif see the comment in * Two of the trace classes (KTR_DEV and KTR_SUBSYS) are special in that * they are really placeholders so that indvidual drivers and subsystems * can map their internal tracing to the general class when they wish to * have tracing enabled and map it to 0 when they don't. Kris