From owner-freebsd-current@FreeBSD.ORG Wed Jun 22 16:20:17 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D07316A41C for ; Wed, 22 Jun 2005 16:20:17 +0000 (GMT) (envelope-from mohan_srinivasan@yahoo.com) Received: from web80602.mail.yahoo.com (web80602.mail.yahoo.com [66.218.79.91]) by mx1.FreeBSD.org (Postfix) with SMTP id 2027A43D1D for ; Wed, 22 Jun 2005 16:20:16 +0000 (GMT) (envelope-from mohan_srinivasan@yahoo.com) Received: (qmail 25394 invoked by uid 60001); 22 Jun 2005 16:20:16 -0000 Message-ID: <20050622162016.25392.qmail@web80602.mail.yahoo.com> Received: from [64.172.44.3] by web80602.mail.yahoo.com via HTTP; Wed, 22 Jun 2005 09:20:16 PDT Date: Wed, 22 Jun 2005 09:20:16 -0700 (PDT) From: Mohan Srinivasan To: Tai-hwa Liang , khetan@os.org.za In-Reply-To: <05062219434218.29380@www.mmlab.cse.yzu.edu.tw> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: current@freebsd.org Subject: Re: Panic potentially related to imgacct_shell.c commit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2005 16:20:17 -0000 Hi, Committing a fix for this issue to -current shortly (today). In the meantime, you can apply this change to your tree. ==== //depot/mohans/freebsd6_nfs/sys/netinet/tcp_sack.c#18 - /homes/mohans/p4/mohans/freebsd6_nfs/sys/netinet/tcp_sack.c ==== @@ -474,8 +474,7 @@ * Since the incoming sack blocks are sorted, we can process them * making one sweep of the scoreboard. */ - while (sblkp - sack_blocks >= 0) { - KASSERT(cur != NULL, ("cur != NULL")); + while (sblkp - sack_blocks >= 0 && cur != NULL) { if (SEQ_GEQ(sblkp->start, cur->end)) { /* * SACKs data beyond the current hole. thanks mohan --- Tai-hwa Liang wrote: > On Tue, 21 Jun 2005, Khetan Gajjar wrote: > [...] > > (kgdb) backtrace > > 165 __asm __volatile("movl %%fs:0,%0" : "=r" (td)); > > #0 doadump () at pcpu.h:165 > > #1 0xc04f9568 in boot (howto=260) at ../../../kern/kern_shutdown.c:397 > > #2 0xc04f987d in panic (fmt=0xc069d6ac "cur != NULL") > > at ../../../kern/kern_shutdown.c:553 > > #3 0xc0593a4c in tcp_sack_option (tp=0xc23c0730, th=0xd4400aac, > > cp=0xc242da66 > "\005\022\002Nu\020\002Nz\223\002N\200\026\002N¬.\223¦T\222!¸Ï+zYã¬+<Û\031\016Öñêî1£\006\177~\017A·\221æºu\227$Ñ9Tõ\232ÿ\003\024\234îÅs¦a\206¨e\236ôLZÔï\r] > imapd[8272]: login: dustpuppy.is.co.za[19", optlen=0) > > at ../../../netinet/tcp_sack.c:478 > > #4 0xc0591a3b in tcp_dooptions (tp=0xc23c0730, to=0xd4400bb4, > > cp=0xc242da66 > "\005\022\002Nu\020\002Nz\223\002N\200\026\002N¬.\223¦T\222!¸Ï+zYã¬+<Û\031\016Öñêî1£\006\177~\017A·\221æºu\227$Ñ9Tõ\232ÿ\003\024\234îÅs¦a\206¨e\236ôLZÔï\r] > imapd[8272]: login: dustpuppy.is.co.za[19", cnt=18, is_syn=0, > > th=0xc242da44) at ../../../netinet/tcp_input.c:2647 > > Try "sysctl net.inet.tcp.sack.enable=0" to see if that helps.> _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"