From owner-svn-src-stable@freebsd.org Fri Jan 27 15:26:04 2017 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5B308CC3E6E; Fri, 27 Jan 2017 15:26:04 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DB907E74; Fri, 27 Jan 2017 15:26:03 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v0RFPsx4025333; Fri, 27 Jan 2017 07:25:54 -0800 (PST) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd-rwg@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v0RFPmVq025332; Fri, 27 Jan 2017 07:25:48 -0800 (PST) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201701271525.v0RFPmVq025332@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r312871 - stable/11/share/zoneinfo In-Reply-To: <201701270911.v0R9BiQr000147@repo.freebsd.org> To: Julian Elischer Date: Fri, 27 Jan 2017 07:25:48 -0800 (PST) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2017 15:26:04 -0000 > Author: julian > Date: Fri Jan 27 09:11:44 2017 > New Revision: 312871 > URL: https://svnweb.freebsd.org/changeset/base/312871 > > Log: > MFH: r308671 > > When you select make OLDTIMEZONES=1 then you need a few added directories > to be made or the command fails > > Sponsored by: panzura > > MFH: r310426 > > If you are going to be run individually to make a new timezone set > then ensure the destination directories exist. > Especially if you define OLDTIMEZONES because the mtree pass > doesn't do it for you. Perhaps it is time to start pre-processing mtree files so this would no longer be the case? > Sponsored by: Panzura > > Modified: > stable/11/share/zoneinfo/Makefile > Directory Properties: > stable/11/ (props changed) > > Modified: stable/11/share/zoneinfo/Makefile > ============================================================================== > --- stable/11/share/zoneinfo/Makefile Fri Jan 27 09:07:11 2017 (r312870) > +++ stable/11/share/zoneinfo/Makefile Fri Jan 27 09:11:44 2017 (r312871) > @@ -67,6 +67,10 @@ TZBUILDSUBDIRS= \ > Pacific \ > SystemV > > +.if defined(OLDTIMEZONES) > +TZBUILDSUBDIRS+= US Mexico Chile Canada Brazil > +.endif > + > .if !defined(_SKIP_BUILD) > all: zoneinfo > .endif > @@ -81,6 +85,8 @@ zoneinfo: yearistype ${TDATA} > > beforeinstall: install-zoneinfo > install-zoneinfo: > + mkdir -p ${DESTDIR}/usr/share/zoneinfo > + cd ${DESTDIR}/usr/share/zoneinfo; mkdir -p ${TZBUILDSUBDIRS} This has the failure mode that your current uid and umask, etc are used in creating the directories. Please add appropriate chown/chmod commands to reflect what mtree would of done had it done this. > cd ${TZBUILDDIR} && \ > find -s * -type f -print -exec ${INSTALL} ${TAG_ARGS} \ > -o ${BINOWN} -g ${BINGRP} -m ${NOBINMODE} \ > _______________________________________________ > svn-src-stable-11@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-stable-11 > To unsubscribe, send any mail to "svn-src-stable-11-unsubscribe@freebsd.org" > -- Rod Grimes rgrimes@freebsd.org