Date: Thu, 2 Aug 2012 00:00:35 +0000 (UTC) From: Sean Bruno <sbruno@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r238981 - head/sys/dev/e1000 Message-ID: <201208020000.q7200ZHu014248@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: sbruno Date: Thu Aug 2 00:00:34 2012 New Revision: 238981 URL: http://svn.freebsd.org/changeset/base/238981 Log: CPU_NEXT() already handles wrapping around to the beginning. Also, in a system with sparse CPU IDs, you can have a valid CPU ID > mp_ncpus (e.g. if you have two CPUs 0 and 4, with mp_maxid == 4 and mp_ncpus == 2). Introduced at svn r235210 Submitted by: jhb@ Reviewed by: jfv@ Modified: head/sys/dev/e1000/if_igb.c Modified: head/sys/dev/e1000/if_igb.c ============================================================================== --- head/sys/dev/e1000/if_igb.c Wed Aug 1 23:05:57 2012 (r238980) +++ head/sys/dev/e1000/if_igb.c Thu Aug 2 00:00:34 2012 (r238981) @@ -2522,7 +2522,6 @@ igb_allocate_msix(struct adapter *adapte "Bound queue %d to cpu %d\n", i,igb_last_bind_cpu); igb_last_bind_cpu = CPU_NEXT(igb_last_bind_cpu); - igb_last_bind_cpu = igb_last_bind_cpu % mp_ncpus; } #if __FreeBSD_version >= 800000 TASK_INIT(&que->txr->txq_task, 0, igb_deferred_mq_start,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201208020000.q7200ZHu014248>