From owner-svn-src-all@FreeBSD.ORG Thu Aug 2 00:00:35 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 78212106564A; Thu, 2 Aug 2012 00:00:35 +0000 (UTC) (envelope-from sbruno@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 62B7D8FC0C; Thu, 2 Aug 2012 00:00:35 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q7200ZbY014250; Thu, 2 Aug 2012 00:00:35 GMT (envelope-from sbruno@svn.freebsd.org) Received: (from sbruno@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q7200ZHu014248; Thu, 2 Aug 2012 00:00:35 GMT (envelope-from sbruno@svn.freebsd.org) Message-Id: <201208020000.q7200ZHu014248@svn.freebsd.org> From: Sean Bruno Date: Thu, 2 Aug 2012 00:00:35 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r238981 - head/sys/dev/e1000 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2012 00:00:35 -0000 Author: sbruno Date: Thu Aug 2 00:00:34 2012 New Revision: 238981 URL: http://svn.freebsd.org/changeset/base/238981 Log: CPU_NEXT() already handles wrapping around to the beginning. Also, in a system with sparse CPU IDs, you can have a valid CPU ID > mp_ncpus (e.g. if you have two CPUs 0 and 4, with mp_maxid == 4 and mp_ncpus == 2). Introduced at svn r235210 Submitted by: jhb@ Reviewed by: jfv@ Modified: head/sys/dev/e1000/if_igb.c Modified: head/sys/dev/e1000/if_igb.c ============================================================================== --- head/sys/dev/e1000/if_igb.c Wed Aug 1 23:05:57 2012 (r238980) +++ head/sys/dev/e1000/if_igb.c Thu Aug 2 00:00:34 2012 (r238981) @@ -2522,7 +2522,6 @@ igb_allocate_msix(struct adapter *adapte "Bound queue %d to cpu %d\n", i,igb_last_bind_cpu); igb_last_bind_cpu = CPU_NEXT(igb_last_bind_cpu); - igb_last_bind_cpu = igb_last_bind_cpu % mp_ncpus; } #if __FreeBSD_version >= 800000 TASK_INIT(&que->txr->txq_task, 0, igb_deferred_mq_start,