From owner-cvs-all Thu Jan 4 10: 7:55 2001 From owner-cvs-all@FreeBSD.ORG Thu Jan 4 10:07:50 2001 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mobile.wemm.org (c1315225-a.plstn1.sfba.home.com [65.0.135.147]) by hub.freebsd.org (Postfix) with ESMTP id 3A52A37B400; Thu, 4 Jan 2001 10:07:50 -0800 (PST) Received: from netplex.com.au (localhost [127.0.0.1]) by mobile.wemm.org (8.11.1/8.11.1) with ESMTP id f04I8Jq10348; Thu, 4 Jan 2001 10:08:20 -0800 (PST) (envelope-from peter@netplex.com.au) Message-Id: <200101041808.f04I8Jq10348@mobile.wemm.org> X-Mailer: exmh version 2.2 06/23/2000 with nmh-1.0.4 To: Nick Hibma Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern makedevops.pl makeobjops.pl In-Reply-To: <200101041341.f04DfPE31302@freefall.freebsd.org> Date: Thu, 04 Jan 2001 10:08:19 -0800 From: Peter Wemm Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Nick Hibma wrote: > n_hibma 2001/01/04 05:41:24 PST > > Modified files: > sys/kern makedevops.pl makeobjops.pl > Log: > Fix a bug in both scripts: HEADER sections were not emitted to the header > file. > > While there fix the layout of function headers (noticable in long headers) > > Fix up some style nits. It's Perl and should be written in that style. > > Revision Changes Path > 1.14 +9 -10 src/sys/kern/makedevops.pl > 1.2 +319 -326 src/sys/kern/makeobjops.pl It is a bug to commit functional changes and reformatting changes in the same commit. Like this, it is practically impossible to see the bug fix you made as it is buried in the noise of the reformatting change. (I dont mean to pick on you specifically, others have been doing this recently too) Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message