Date: Mon, 30 Dec 1996 23:19:12 +0100 (MET) From: sos@FreeBSD.ORG To: proff@iq.org (Julian Assange) Cc: hackers@FreeBSD.ORG Subject: Re: divert code not thread/smp compatible Message-ID: <199612302219.XAA00733@ravenock.cybercity.dk> In-Reply-To: <199612301928.GAA29162@profane.iq.org> from Julian Assange at "Dec 31, 96 06:28:55 am"
next in thread | previous in thread | raw e-mail | index | archive | help
In reply to Julian Assange who wrote:
>
> /*
> * ip_input() and ip_output() set this secret value before calling us to
> * let us know which divert port to divert a packet to; this is done so
> * we can use the existing prototype for struct protosw's pr_input().
> * This is stored in host order.
> */
> u_short ip_divert_port;
>
> /*
> * We set this value to a non-zero port number when we want the call to
> * ip_fw_chk() in ip_input() or ip_output() to ignore ``divert <port>''
> * chain entries. This is stored in host order.
> */
> u_short ip_divert_ignore;
>
> Is this an acceptable trick in the FreeBSD kernel, passing parameters
> with global variables?
No, its just bad, bad....
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Søren Schmidt (sos@FreeBSD.org) FreeBSD Core Team
Even more code to hack -- will it ever end
..
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199612302219.XAA00733>