From nobody Tue Jul 26 16:31:17 2022 X-Original-To: freebsd-arch@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Lsj8Z1Jwhz4XSRB for ; Tue, 26 Jul 2022 16:31:10 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-vs1-xe31.google.com (mail-vs1-xe31.google.com [IPv6:2607:f8b0:4864:20::e31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lsj8Y2PmFz3YBF for ; Tue, 26 Jul 2022 16:31:09 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-vs1-xe31.google.com with SMTP id x125so14149713vsb.13 for ; Tue, 26 Jul 2022 09:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=ZdHP8dGNG/nHA15sapnrJUHEPMLuxXaxIOkR0zVzHI0=; b=zh4exVePn5vjImEC6E6mxbtFuBNS6tL0TESBgq/wG9YJzyDSF3AsacbzU+q0wtlwMk K3fI/ylqVzeH0ic8t4ToqFSyShTB5oPb/sm30mex95Cm08Wz5L+n5sZEn7o7mfTrCXQq zlDaUAKgQHGUeQBWdDsyQ3L1TtsDLJEpaYnWFZx0sla1qCvlauLqEgfrZ2d/hXtKmXD5 DRqvFBVK/od6SR2cT5IAyaXrciGFyFofKPILsmTS7DwUBGjhRjJVCUocuOcfCrjxED+h jDY9aPaQV9ttVfVP9GXNfqvOEJRjBMb1pU0Lm3m0eAuqrzVGt/pv687HZrZ4pjZZYowB mHhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=ZdHP8dGNG/nHA15sapnrJUHEPMLuxXaxIOkR0zVzHI0=; b=ZJhpj/BRNe27pTt5UAkBtE3zNxz04NJW/KHDj5wT6vDAIZNambreniGbyN+f6vwBXo oPr9VjVsZkFJWzfjzks+EBURxh9MsqxNZztYafL/bp5SGorjonMqXtO2aRSkh7/Ar6vW aNIf2fkDPGbxlQzLwujsCtPdKH1kCzuh+DzGZMEE9TWlPg99+vyTdj4XZMNShfCkPyQM N8cqDZ7JG+gr1NhAygI45EK/2QcqI4ZfxF36F8iUCmE9kTo925QJrCtpWDjBOWyDut7D mt2y8sbP/bLoxjRX0n7REFG3ob7WEbGP5pqNZ/O3V3JAsHUc3Cq0nJjLLqfub5jk0YAU nNNw== X-Gm-Message-State: AJIora9rp/A3jdj+EL7Gj14og3nr5RxDdq1o4p/qzLwAOWDlBaSiRbc7 JjH6Q3VvTdkHU0VKNlLCIGozXzlrd+cVZSK/aBeo4Dq9Ot6N5Q== X-Google-Smtp-Source: AGRyM1unwD4MBh5Ex4TMI5rZk3UKykJFyujMGdV1Fm2dai0s08D1DiPpQrrSTje9gYsoMlOfHwo84QHd+F1ACIx6zzM= X-Received: by 2002:a67:f351:0:b0:358:3289:1c00 with SMTP id p17-20020a67f351000000b0035832891c00mr5227172vsm.40.1658853067787; Tue, 26 Jul 2022 09:31:07 -0700 (PDT) List-Id: Discussion related to FreeBSD architecture List-Archive: https://lists.freebsd.org/archives/freebsd-arch List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arch@freebsd.org MIME-Version: 1.0 From: Warner Losh Date: Tue, 26 Jul 2022 10:31:17 -0600 Message-ID: Subject: Stlye(9) strengthen statements on not using K&R function definitions To: "freebsd-arch@freebsd.org" Content-Type: multipart/alternative; boundary="000000000000d730a705e4b7d32b" X-Rspamd-Queue-Id: 4Lsj8Y2PmFz3YBF X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=zh4exVeP; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::e31) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-0.998]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; MLMMJ_DEST(0.00)[freebsd-arch@freebsd.org]; R_SPF_NA(0.00)[no SPF record]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TO_DN_EQ_ADDR_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::e31:from]; PREVIOUSLY_DELIVERED(0.00)[freebsd-arch@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; DMARC_NA(0.00)[bsdimp.com]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N --000000000000d730a705e4b7d32b Content-Type: text/plain; charset="UTF-8" Greetings I've posted a review https://reviews.freebsd.org/D35945 which strengths statements about K&R definitions and declarations: don't use them. Most of the K&R code has been removed from the tree (ufs being the last straggler). Future versions of the C standard will remove the K&R definitions and declaration syntax. clang 15 will whine about this construct. The time is ripe to move to language that suggests an outright prohibition. Comments about language? Make them in phabricator. Comments about the idea? Reply here Warner --000000000000d730a705e4b7d32b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Greetings

I've posted a = review https://reviews.freeb= sd.org/D35945 which strengths statements about K&R definitions and = declarations: don't use them. Most of the K&R code has been removed= from the tree (ufs being the last straggler). Future versions of the C sta= ndard will remove the K&R definitions and declaration syntax. clang 15 = will whine about this construct.

The time is ripe = to move to language that suggests an outright prohibition.

Comments about language? Make them in phabricator.
Comme= nts about the idea? Reply here

Warner

--000000000000d730a705e4b7d32b--