From owner-freebsd-arch Sat Mar 17 15:42:32 2001 Delivered-To: freebsd-arch@freebsd.org Received: from gndrsh.dnsmgr.net (GndRsh.dnsmgr.net [198.145.92.4]) by hub.freebsd.org (Postfix) with ESMTP id 52D2037B719; Sat, 17 Mar 2001 15:42:28 -0800 (PST) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.9.3/8.9.3) id PAA59546; Sat, 17 Mar 2001 15:42:14 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <200103172342.PAA59546@gndrsh.dnsmgr.net> Subject: Re: Proposal for the CPU interrupt API In-Reply-To: <200103171925.f2HJP4x95161@earth.backplane.com> from Matt Dillon at "Mar 17, 2001 11:25:04 am" To: dillon@earth.backplane.com (Matt Dillon) Date: Sat, 17 Mar 2001 15:42:13 -0800 (PST) Cc: jhb@FreeBSD.ORG (John Baldwin), arch@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > :and by otherwise I included comments in code. Take this one for example: > :>From sys/i386/isa/if_sr.c > : /* > : * XXX Disable all interrupts for now. I think if you are using the > : * dmac you don't use these interrupts. > : */ > : SRC_PUT8(hc->sca_base, msci->ie0, 0); > : SRC_PUT8(hc->sca_base, msci->ie1, 0x0C); > : > :writting 0x0C to msci->ie1 does NOT disable all interrupts!!! > > Well, those XXX's seem to indicate that the author wasn't so sure about > what he was doing either. Quite a useful comment, I think! The XXX is more than likely with regards to the ``I think if you are...'' part of the comment. (And it is wrong about that as well, you need to use most of the interrupts, even when using the dmac, to deal with things like DMA underruns and overruns.) > > % fgrep XXX vm/* | wc -l > 108 > > -Matt > -- Rod Grimes - KD7CAX @ CN85sl - (RWG25) rgrimes@gndrsh.dnsmgr.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message