From owner-dev-commits-src-all@freebsd.org Tue Feb 9 14:53:49 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2B7AE540FE2; Tue, 9 Feb 2021 14:53:49 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DZm9n0m66z56Dx; Tue, 9 Feb 2021 14:53:49 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1612882429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3i2hmKIWaJq/RqLU4EInUg171v4y61U8XT30xW3QYZ4=; b=bm4bNuAeyhV+YmlQtKwIg6eOj+eVTN6UT4j9a0pi6LsPXlE19yfMTCePrX+wUCxtcdOpeD tlHYNrQAZgxue4JbVd8zQCDuthMDulka+gWDCX+0ZhxMk52OM63gR6/fj/y8X0q5HUfa5u MgQBltHBoJKvHrrIQb4BL+Lcd8n0U/HUKnMwF34PNYB8iEPrP4HHTSDVHgiW81xR1hOwbW Axqv4HKF635fdZCHbnt3wfjV2vY2/WYuzMCHKQELHRaXiiGAYVS3r6JTXryhWnCSo5E4Sa +EF6qrByrwmq7EuxhEI24U+Zh/WhCHH6scZQuFmAd5xyYTz4NGxBxdycC7c6EA== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 0BDDB181B2; Tue, 9 Feb 2021 14:53:49 +0000 (UTC) Date: Tue, 9 Feb 2021 14:53:48 +0000 From: Alexey Dokuchaev To: Mateusz Guzik Cc: Jessica Clarke , Kevin Bowling , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: af366d353b84 - main - amd64: implement strlen in assembly Message-ID: <20210209145348.GA70871@FreeBSD.org> References: <202102081915.118JFXkJ067892@gitrepo.freebsd.org> <3E64387A-42DD-4470-8893-5B774F19754E@freebsd.org> <8E61EA5C-39D1-49CC-8319-06E9192FF735@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1612882429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3i2hmKIWaJq/RqLU4EInUg171v4y61U8XT30xW3QYZ4=; b=abQ6z3eTzwGFH8kIhys9P1E6rtj7vgkzsaPGvSm4lk2lNDp+yKpaspuKkKoez34u7Ee874 YP2XKgfdHuYgwFYbyisdCUfnVrtYm3v8T9O20Z7oIihsI8olYCRtgcGTv3Ncwesm7BxNoz tFPSk5xrx1medr4ViaJi7dZHWkIC202S5XclP6+MoNHdsD57ghfH29nudzAWhTny14I84J WM7MllrQchcTIdjh/rVr6RcTaB+nNmYUKacmeC9T/ooJyo43L8hJcXy668ltahhwAIfflD ibX5SLJDh50esU0vpc2hXo9vK8j6QxBGr6ZU1uJgqQFXOqx9gKWBXK3ij6U0SA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1612882429; a=rsa-sha256; cv=none; b=FV2DwyGN+51Do8Z3YFTt6oNw9J6Ymcl3n0qLbN4i3d5Cpx7u1vGwLoOKxL1aJSbs/wrCha 2TwGaUzF10jeLmYWhFJXpX7PtbzBeYG9qj7bw4ZGWOn0+fE86fxXkcQDaFH8TZlWOZYOXB 8Ftigv+1W2/Skmcp5KjdeavcpJx9eRnlnaUB7fq3l91Mms+VXvGB5T/m7eE/nPdLn3j6hS 9Gm7lMUJHXrJG+0gDLMB3eUYp3/TViHms8cKz7cqp9WBp9LWtnjK4lUv2A34NSBCX2E068 epX5rvJRiD76DAyHZpuv/ZCERaSHtHzu+3rqo5mPMlSxSszdfpTqGif48Tm8YA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Feb 2021 14:53:49 -0000 On Tue, Feb 09, 2021 at 02:41:15PM +0100, Mateusz Guzik wrote: > ... > More, if reviews were mandatory, I would expect their quality to go > down even further, making them even less likely to prevent breakage. Exactly that. In fact, the good reviews are typically coming from people who care. But those you'll get regardless of whether you've asked for them. ./danfe