From owner-freebsd-bugs@FreeBSD.ORG Tue May 22 12:20:04 2007 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9B7AA16A468 for ; Tue, 22 May 2007 12:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 640EC13C44C for ; Tue, 22 May 2007 12:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l4MCK4ag016877 for ; Tue, 22 May 2007 12:20:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l4MCK41v016876; Tue, 22 May 2007 12:20:04 GMT (envelope-from gnats) Resent-Date: Tue, 22 May 2007 12:20:04 GMT Resent-Message-Id: <200705221220.l4MCK41v016876@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Raymond Pasco Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EA82116A421 for ; Tue, 22 May 2007 12:10:30 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [69.147.83.33]) by mx1.freebsd.org (Postfix) with ESMTP id DB35913C4B8 for ; Tue, 22 May 2007 12:10:30 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l4MCAU7B086177 for ; Tue, 22 May 2007 12:10:30 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id l4MC5SOD085474; Tue, 22 May 2007 12:05:28 GMT (envelope-from nobody) Message-Id: <200705221205.l4MC5SOD085474@www.freebsd.org> Date: Tue, 22 May 2007 12:05:28 GMT From: Raymond Pasco To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.0 Cc: Subject: misc/112861: lesspipe.sh breaks on filenames containing spaces X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2007 12:20:04 -0000 >Number: 112861 >Category: misc >Synopsis: lesspipe.sh breaks on filenames containing spaces >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue May 22 12:20:03 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Raymond Pasco >Release: 6.2-RC2 >Organization: >Environment: FreeBSD nina.caedescontego.net 6.2-RC2 FreeBSD 6.2-RC2 #0: Sun Dec 24 23:17:34 UTC 2006 root@dessler.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: lesspipe.sh (src/usr.bin/less/lesspipe.sh) breaks on filenames containing spaces. This is because it uses a naked $1 as the argument for decompress, gunzip, and bunzip2, where it should use "$1" instead. >How-To-Repeat: use lesspipe.sh or less(1) with the LESSOPEN environment variable set to use lesspipe.sh on a compressed file with spaces in its name >Fix: attached patch Patch attached with submission follows: diff -r -u src.orig/usr.bin/less/lesspipe.sh src/usr.bin/less/lesspipe.sh --- src.orig/usr.bin/less/lesspipe.sh Tue May 22 07:56:40 2007 +++ src/usr.bin/less/lesspipe.sh Tue May 22 07:56:59 2007 @@ -5,12 +5,12 @@ case "$1" in *.Z) - exec uncompress -c $1 2>/dev/null + exec uncompress -c "$1" 2>/dev/null ;; *.gz) - exec gzip -d -c $1 2>/dev/null + exec gzip -d -c "$1" 2>/dev/null ;; *.bz2) - exec bzip2 -d -c $1 2>/dev/null + exec bzip2 -d -c "$1" 2>/dev/null ;; esac >Release-Note: >Audit-Trail: >Unformatted: