From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Nov 28 21:11:04 2005 Return-Path: X-Original-To: freebsd-ports-bugs@FreeBSD.org Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B1E9816A422; Mon, 28 Nov 2005 21:11:04 +0000 (GMT) (envelope-from charlie@schluting.com) Received: from mailhost.schluting.com (schluting.com [131.252.214.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 776AC43D88; Mon, 28 Nov 2005 21:10:02 +0000 (GMT) (envelope-from charlie@schluting.com) Received: from localhost (localhost.cat.pdx.edu [127.0.0.1]) by mailhost.schluting.com (Postfix) with ESMTP id 01FC12120; Mon, 28 Nov 2005 13:09:59 -0800 (PST) Received: from mailhost.schluting.com ([127.0.0.1]) by localhost (schluting.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 66089-10; Mon, 28 Nov 2005 13:09:54 -0800 (PST) Received: from [131.252.214.62] (pepe.cat.pdx.edu [131.252.214.62]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailhost.schluting.com (Postfix) with ESMTP id A3A57214D; Mon, 28 Nov 2005 13:09:54 -0800 (PST) Message-ID: <438B7222.60002@schluting.com> Date: Mon, 28 Nov 2005 13:09:54 -0800 From: Charlie Schluting User-Agent: Mozilla Thunderbird 1.0.6 (Macintosh/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Edwin Groothuis References: <200511242353.jAONrpmx045000@freefall.freebsd.org> In-Reply-To: <200511242353.jAONrpmx045000@freefall.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by your mom at schluting.com Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/84530: [New Port] net-mgmt/ourmon: Network Monitoring and Anomaly Detection System X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Nov 2005 21:11:04 -0000 Edwin Groothuis wrote: > Synopsis: [New Port] net-mgmt/ourmon: Network Monitoring and Anomaly Detection System > > State-Changed-From-To: open->closed > State-Changed-By: edwin > State-Changed-When: Thu Nov 24 23:49:17 GMT 2005 > State-Changed-Why: First, I found a bug in the Makefile. (used spaces instead of a tab) Can someone change the spaces on line 51 to a tab? (is a patch necessary for this?) > Please let me nag you for a second: > > - missing pkg-plist and/or incorrect PLIST_DIR/PLIST_FILES I was under the impression that PLIST_DIRS= would use $PREFIX/name. I don't know where I got that idea. Thanks for generating the pkg-plist file. > - lots of confusing and out-of-order targets in the Makefile I know :( See below.. > - why NO_PACKAGE? This program has multiple parts, a web front-end and a C/perl back-end. The install process requires user interaction.. users can install either or both parts. > - please create a pkg-install script which takes care of the > pre-install > - see if you can extract the building phase from the installation > phase. Well. It's calling a large perl script that's doing the install. In the script, it builds various C programs, talks to the user, and installs more files. There's really no way to make it ports-friendly in this regard, without rewriting the perl installer completely. That's a huge task.. It might be possible to provide default answers to the perl install script via a pkg-install script, if I really have to make it package-able. > Committed, thanks! > Thank you! -Charlie