From owner-svn-src-head@FreeBSD.ORG Thu Jan 22 23:50:51 2009 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by hub.freebsd.org (Postfix) with ESMTP id 916A41065713; Thu, 22 Jan 2009 23:50:50 +0000 (UTC) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: Maxim Sobolev Date: Thu, 22 Jan 2009 18:50:36 -0500 User-Agent: KMail/1.6.2 References: <200901221706.n0MH6XN1017768@svn.freebsd.org> <200901221536.19137.jkim@FreeBSD.org> <4978FC49.9080806@FreeBSD.org> In-Reply-To: <4978FC49.9080806@FreeBSD.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200901221850.37708.jkim@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn: head/sys: compat/linprocfs i386/cpufreq X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2009 23:50:51 -0000 On Thursday 22 January 2009 06:07 pm, Maxim Sobolev wrote: > Jung-uk Kim wrote: > > On Thursday 22 January 2009 03:24 pm, Maxim Sobolev wrote: > >> Jung-uk Kim wrote: > >>> Author: jkim > >>> Date: Thu Jan 22 17:06:33 2009 > >>> New Revision: 187594 > >>> URL: http://svn.freebsd.org/changeset/base/187594 > >>> > >>> Log: > >>> Replace couple of strcmp(cpu_vendor, "foo") with > >>> cpu_vendor_id for i386 > >> > >> What about amd64? > > > > It is #ifdef'ed out in linprocfs.c and smist.c is i386-specific, > > i.e., it does not compile on amd64. > > No, it's not. The function linprocfs_docpuinfo() are the same for > both amd64 and i386, so that you've just broken it for amd64 with > this commit. #ifdef was added with it: http://docs.freebsd.org/cgi/mid.cgi?200901221706.n0MH6XN1017768 Jung-uk Kim