From owner-p4-projects  Wed Dec  4 22:57:42 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 02A3437B404; Wed,  4 Dec 2002 22:57:41 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8F02837B401
	for <perforce@freebsd.org>; Wed,  4 Dec 2002 22:57:40 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4AA0143E4A
	for <perforce@freebsd.org>; Wed,  4 Dec 2002 22:57:40 -0800 (PST)
	(envelope-from marcel@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id gB56rLmV007421
	for <perforce@freebsd.org>; Wed, 4 Dec 2002 22:53:21 -0800 (PST)
	(envelope-from marcel@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id gB56rLCf007418
	for perforce@freebsd.org; Wed, 4 Dec 2002 22:53:21 -0800 (PST)
Date: Wed, 4 Dec 2002 22:53:21 -0800 (PST)
Message-Id: <200212050653.gB56rLCf007418@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to marcel@freebsd.org using -f
From: Marcel Moolenaar <marcel@FreeBSD.org>
Subject: PERFORCE change 21956 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://perforce.freebsd.org/chv.cgi?CH=21956

Change 21956 by marcel@marcel_nfs on 2002/12/04 22:52:51

	When the address hint is non-zero and we don't have the RSDP at
	the given address, bail out. Don't revert to scanning. The
	Itanium prototype has both ACPI1 and ACPI2 tables, but the ACPI1
	RSDP is bogus -> *hang*
	
	We seem to be dereferencing a null pointer on the Itanium box.
	Something's not quite right...

Affected files ...

.. //depot/projects/ia64/usr.sbin/acpi/acpidump/acpi_user.c#5 edit

Differences ...

==== //depot/projects/ia64/usr.sbin/acpi/acpidump/acpi_user.c#5 (text+ko) ====

@@ -113,6 +113,9 @@
 		return (acpi_map_physical(hint, sizeof(struct ACPIrsdp)));
 	}
 notrsd:
+	if (hint != 0)
+		errx(1, "ACPI root pointer not at 0x%lx", hint);
+
 	for (i = 0; i < 1024 * 1024; i += 16) {
 		pread(acpi_mem_fd, buf, 16, i);
 		if (!memcmp(buf, "RSD PTR ", 8)) {

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message