From owner-freebsd-current@FreeBSD.ORG Sat Sep 14 19:17:14 2013 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 29E2F4C7; Sat, 14 Sep 2013 19:17:14 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org [204.13.248.66]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id F257325B1; Sat, 14 Sep 2013 19:17:13 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1VKvLE-000P9T-At; Sat, 14 Sep 2013 19:17:12 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id r8EJH9eE010884; Sat, 14 Sep 2013 13:17:09 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19//v3Q3D3wvkZhi9wC02Kb Subject: Re: aicasm build error From: Ian Lepore To: Dimitry Andric In-Reply-To: <55AEA8C2-9C47-4AB4-8626-EB7AC28839FC@FreeBSD.org> References: <1379181005.1197.24.camel@revolution.hippie.lan> <55AEA8C2-9C47-4AB4-8626-EB7AC28839FC@FreeBSD.org> Content-Type: text/plain; charset="us-ascii" Date: Sat, 14 Sep 2013 13:17:09 -0600 Message-ID: <1379186229.1197.31.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: freebsd-current@FreeBSD.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2013 19:17:14 -0000 On Sat, 2013-09-14 at 20:42 +0200, Dimitry Andric wrote: > On Sep 14, 2013, at 19:50, Ian Lepore wrote: > > For a while I've been getting a build error on aicasm during the early > > steps of the build. Today I finally dug into it and discovered it's > > because the build is using a mix of header files, some from /usr/include > > on the build host, and some from obj/... for the target being built. It > > happens because dev/aic7xxx/aicasm/Makefile contains CFLAGS+= -I. and > > the current directory when aicasm builds is obj/.../. In my > > case it was picking up machine/_types.h from objdir. > > > > Apparently this is usually harmless, but if the build host system and > > the target versions are far enough apart, or with a cross-build where > > the host and target are different architectures, you can get problems. > > > > After a little digging, I just now discovered Marcel fixed this long ago > > in r70000, but then it got undone in r236578 a couple months ago. Is > > there any reason not to restore Marcel's fix, such as with the attached > > patch? > > It got undone for a specific reason, which is mentioned in the commit > message for r236578. > > This hack might make it work, but it might also cause other issues. The > problem really is how to make sure aicasm is compiled with the *host* > compiler, not the compiler from /usr/obj. > > -Dimitry > Actually, the commit message that removed it talks about -Wunused-arguments and -Werror and -nostdinc, and then says -nostdinc is removed, and says nothing at all about the fact that -I/usr/include was also removed at the same time. I'm proposing adding back the -I but not the -nostdinc. Another possibly-viable fix is to remove the -I. so that it doesn't pick up headers from obj/..., which makes buildkernel work for me, but maybe it would cause the aicasm build to fail if built separately or something. -- Ian