From owner-svn-src-head@FreeBSD.ORG Tue Feb 10 23:31:52 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 750C7106567B; Tue, 10 Feb 2009 23:31:52 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 4B1F68FC08; Tue, 10 Feb 2009 23:31:52 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n1ANVplM030098 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 10 Feb 2009 15:31:51 -0800 (PST) (envelope-from sam@freebsd.org) Message-ID: <49920E67.60805@freebsd.org> Date: Tue, 10 Feb 2009 15:31:51 -0800 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.18 (X11/20081209) MIME-Version: 1.0 To: Alexander Motin References: <200902102322.n1ANMTgW007393@svn.freebsd.org> In-Reply-To: <200902102322.n1ANMTgW007393@svn.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-sonic.net-Metrics: ebb.errno.com; whitelist Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r188464 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2009 23:31:53 -0000 Alexander Motin wrote: > Author: mav > Date: Tue Feb 10 23:22:29 2009 > New Revision: 188464 > URL: http://svn.freebsd.org/changeset/base/188464 > > Log: > Check for device_set_devclass() errors and skip driver probe/attach if any. > Attach call without devclass set crashes the system. > > On resume AHCI driver sometimes tries to create duplicate adX device. > It is surely his own problem, but IMHO it is not a reason to crash here. > Other reasons are also possible. > > Please leave a comment in the code that this is basically a WAR for buggy drivers. Sam