From owner-freebsd-net@freebsd.org  Tue May  8 11:45:16 2018
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C2EFAFB2E91
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Tue,  8 May 2018 11:45:16 +0000 (UTC)
 (envelope-from harsh@chelsio.com)
Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 32EFA75354;
 Tue,  8 May 2018 11:45:15 +0000 (UTC)
 (envelope-from harsh@chelsio.com)
Received: from [10.193.189.121] (harsh.asicdesigners.com [10.193.189.121])
 by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id w48Bj8wv000491;
 Tue, 8 May 2018 04:45:09 -0700
To: freebsd-net@freebsd.org, tj@enoti.me, tj@enoti.me
Cc: Navdeep Parhar <navdeep@chelsio.com>, John Baldwin <jhb@freebsd.org>,
 sonyarpitad@chelsio.com
From: Harsh Jain <harsh@chelsio.com>
Subject: Bug: Newreno; Seems Memory leak in newreno_cb_init
Message-ID: <58ab6c13-f9c4-b4d7-7f2c-eade3749457f@chelsio.com>
Date: Tue, 8 May 2018 17:14:49 +0530
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 May 2018 11:45:16 -0000

Hi All,

We have observed memory leak with TCP network traffic in "newreno".

Output of vmstat -m

   in_mfilter     3     3K       -        3  1024
     in_multi     4     1K       -        4  256
  ip_moptions     6     1K       -        6  64,256
encap_export_host     2     2K       -        2  1024
 newreno data 394849273 6169520K       - 394849273  16
    sctp_a_it     0     0K       -        5  16
     sctp_vrf     1     1K       -        1  64
     sctp_ifa     7     1K       -        7  128
     sctp_ifn     4     1K       -        4  128

There is 1 malloc in "newreno_cb_init" whose pointer is not saved in any global structure to free the same.

Is this a BUG?

Regards

Harsh Jain