From owner-freebsd-current  Wed Oct  2 16:17: 7 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5A72637B401; Wed,  2 Oct 2002 16:17:06 -0700 (PDT)
Received: from espresso.q9media.com (espresso.q9media.com [65.39.129.122])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E5C2443E6A; Wed,  2 Oct 2002 16:17:05 -0700 (PDT)
	(envelope-from mike@espresso.q9media.com)
Received: by espresso.q9media.com (Postfix, from userid 1002)
	id 1B0809E57; Wed,  2 Oct 2002 19:09:55 -0400 (EDT)
Date: Wed, 2 Oct 2002 19:09:55 -0400
From: Mike Barcroft <mike@FreeBSD.org>
To: luigi@FreeBSD.org
Cc: current@FreeBSD.org
Subject: Re: Fatal warnings breaks ipfw on LP64
Message-ID: <20021002190955.D90848@espresso.q9media.com>
References: <20020902124032.D94253@espresso.q9media.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20020902124032.D94253@espresso.q9media.com>; from mike@FreeBSD.org on Mon, Sep 02, 2002 at 12:40:32PM -0400
Organization: The FreeBSD Project
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

It's been one month, have you made any progress on this?

Mike Barcroft <mike@FreeBSD.org> writes:
> 
> cc1: warnings being treated as errors
> /usr/src/sys/netinet/ip_fw2.c: In function `ipfw_ctl':
> /usr/src/sys/netinet/ip_fw2.c:2508: warning: cast from pointer to integer of different size
> /usr/src/sys/netinet/ip_fw2.c:2521: warning: cast from pointer to integer of different size
> 
> Some of the code in question looks questionable:
>                         /*
>                          * abuse 'next_rule' to store the set_disable word
>                          */
>                         (u_int32_t)(((struct ip_fw *)bp)->next_rule) =
>                                 set_disable;
> 
> The rvalue is being cast in an assignment to make a pointer store an
> integer?  Surely this can be written better.
> 
> Best regards,
> Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message