From owner-freebsd-bugs@FreeBSD.ORG Tue Mar 21 06:40:18 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 282B616A420 for ; Tue, 21 Mar 2006 06:40:18 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 95EAD43D4C for ; Tue, 21 Mar 2006 06:40:17 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2L6eHiC074001 for ; Tue, 21 Mar 2006 06:40:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2L6eHL6074000; Tue, 21 Mar 2006 06:40:17 GMT (envelope-from gnats) Resent-Date: Tue, 21 Mar 2006 06:40:17 GMT Resent-Message-Id: <200603210640.k2L6eHL6074000@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ganbold Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B2BE516A41F for ; Tue, 21 Mar 2006 06:32:59 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B3E743D49 for ; Tue, 21 Mar 2006 06:32:59 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k2L6WxGg062337 for ; Tue, 21 Mar 2006 06:32:59 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k2L6Wxgw062336; Tue, 21 Mar 2006 06:32:59 GMT (envelope-from nobody) Message-Id: <200603210632.k2L6Wxgw062336@www.freebsd.org> Date: Tue, 21 Mar 2006 06:32:59 GMT From: Ganbold To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: misc/94767: rcorder dumps core when does not use a proper RCng script (dansguardian) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2006 06:40:18 -0000 >Number: 94767 >Category: misc >Synopsis: rcorder dumps core when does not use a proper RCng script (dansguardian) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Mar 21 06:40:16 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Ganbold >Release: FreeBSD-7.0-CURRENT >Organization: >Environment: FreeBSD gw.micom.mng.net 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Tue Mar 21 09:00:50 ULAT 2006 tsgan@gw.micom.mng.net:/usr/obj/usr/src/sys/GW i386 >Description: There is a rcorder problem with dansguardian-2.8.0.6 startup script on FreeBSD-7.0-CURRENT. When booting rcorder complains and dumps core. When I manually run rcorder -s nostart /etc/rc.d/* /usr/local/etc/rc.d/* it shows: . rcorder: Circular dependency on file `/usr/local/etc/rc.d/start-dg.sh'. rcorder: Circular dependency on provision `squid' in file `/usr/local/etc/rc.d/start-dg.sh'. /etc/rc.d/LOGIN /usr/local/etc/rc.d/squid.sh /usr/local/etc/rc.d/start-dg.sh Segmentation fault (core dumped) >How-To-Repeat: Install dansguardian-2.8.0.6 and squid (Squid Cache: Version 2.5.STABLE12) from ports and try to reboot. Or after installation one could run command: rcorder -s nostart /etc/rc.d/* /usr/local/etc/rc.d/* >Fix: --- rcorder.c Tue Mar 21 14:10:58 2006 +++ rcorder.c-new Tue Mar 21 14:10:41 2006 @@ -798,8 +798,10 @@ DPRINTF((stderr, "nuking %s\n", fnode->filename)); if (was_set == 0) { - free(fnode->filename); - free(fnode); + if(fnode->next == NULL){ + free(fnode->filename); + free(fnode); + } } } >Release-Note: >Audit-Trail: >Unformatted: