From owner-freebsd-current@FreeBSD.ORG Fri Dec 30 13:25:47 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 65998106564A for ; Fri, 30 Dec 2011 13:25:47 +0000 (UTC) (envelope-from break19@gmail.com) Received: from mail-yx0-f182.google.com (mail-yx0-f182.google.com [209.85.213.182]) by mx1.freebsd.org (Postfix) with ESMTP id 1EFFB8FC12 for ; Fri, 30 Dec 2011 13:25:46 +0000 (UTC) Received: by yenl9 with SMTP id l9so9186948yen.13 for ; Fri, 30 Dec 2011 05:25:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=9b+nxi5xvEeJLt2v11v9WViApgGT5+JSGh6SmXWOalo=; b=bah3dGvvlelzBF6W12XpWsJj5Pu/4aAWESlMtOr6GXrurGvHGw65gRNNozlxyuNsLL kjMwxdhAzOCzhNpbfVXw+XfYNPIR5p4hTRv9sJI/crgICD6KPZs0DPYaCHWSQHr2OPIb w+szHm0CHB77K4QGwG0pLV8uWP6DTLIbQZ0V0= Received: by 10.236.195.73 with SMTP id o49mr2605661yhn.71.1325251546498; Fri, 30 Dec 2011 05:25:46 -0800 (PST) Received: from [192.168.4.106] (c-98-230-64-224.hsd1.al.comcast.net. [98.230.64.224]) by mx.google.com with ESMTPS id j11sm32188808anl.8.2011.12.30.05.25.45 (version=SSLv3 cipher=OTHER); Fri, 30 Dec 2011 05:25:45 -0800 (PST) Message-ID: <4EFDBBDB.4090506@gmail.com> Date: Fri, 30 Dec 2011 07:25:47 -0600 From: Chuck Burns User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: freebsd-current@freebsd.org References: <20111226101040.GA6361@freebsd.org> <4EFDB76C.1030901@FreeBSD.org> In-Reply-To: <4EFDB76C.1030901@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [rfc] removing/conditionalising WERROR= in Makefiles X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Dec 2011 13:25:47 -0000 On 12/30/2011 7:06 AM, Dimitry Andric wrote: > On 2011-12-26 11:10, Alexander Best wrote: >> that's why i'd like to propose the following patch. i ran a full >> tinderbox run >> against r228878 and it suceeded. > > Did you also try this with clang? For example the xfs module alone gets > a whole slew of warnings, which would be fatal if WERROR= was removed: > > sys/gnu/fs/xfs/xfs_dir2_block.c:1149:17: warning: array index of '1' > indexes past the end of an array (that contains 1 element) [-Warray-bounds] > dep->name[0] = dep->name[1] = '.'; > ^ ~ > sys/gnu/fs/xfs/xfs_dir2_data.h:90:2: note: array 'name' declared here > __uint8_t name[1]; /* name bytes, no null */ > ^ > 1 warning generated. just as an aside, the XFS module didn't seem to work when I last attempted to use it, so it may be worth just removing it? -- Chuck Burns The Southern Libertarian http://www.thesouthernlibertarian.com/